fabi/Snappy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #175 from Quuxplusone/suggest-override

Browse Source 
Fix -Wsuggest-override warnings from Clang
This commit is contained in:
danilak-G
2024-04-04 20:04:38 +01:00
committed by GitHub
parent 6b2eb7028b 41a3ade229
commit 23b3286820
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
snappy.cc
View File

@@ -1888,16 +1888,16 @@ class SnappyIOVecReader : public Source {
if (total_size > 0 && curr_size_remaining_ == 0) Advance(); if (total_size > 0 && curr_size_remaining_ == 0) Advance();
} }
~SnappyIOVecReader() = default; ~SnappyIOVecReader() override = default;
size_t Available() const { return total_size_remaining_; } size_t Available() const override { return total_size_remaining_; }
const char* Peek(size_t* len) { const char* Peek(size_t* len) override {
*len = curr_size_remaining_; *len = curr_size_remaining_;
return curr_pos_; return curr_pos_;
} }
void Skip(size_t n) { void Skip(size_t n) override {
while (n >= curr_size_remaining_ && n > 0) { while (n >= curr_size_remaining_ && n > 0) {
n -= curr_size_remaining_; n -= curr_size_remaining_;
Advance(); Advance();
@@ -2535,7 +2535,6 @@ bool SnappyScatteredWriter<Allocator>::SlowAppendFromSelf(size_t offset,
class SnappySinkAllocator { class SnappySinkAllocator {
public: public:
explicit SnappySinkAllocator(Sink* dest) : dest_(dest) {} explicit SnappySinkAllocator(Sink* dest) : dest_(dest) {}
~SnappySinkAllocator() {}
char* Allocate(int size) { char* Allocate(int size) {
Datablock block(new char[size], size); Datablock block(new char[size], size);