fabi/Snappy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

'size' remains unused if none of ZLIB, LZO and LZ4 are available.

Browse Source 
While we're here, take care of a couple of lint warnings by converting CHECK(a != b) to CHECK_NE(a, b).

PiperOrigin-RevId: 369132446
This commit is contained in:
atdt
2021-04-19 00:59:10 +00:00
committed by Victor Costan
parent 78650d126a
commit 9c1be17938
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
snappy_test_tool.cc
View File

@@ -204,7 +204,7 @@ bool Compress(const char* input, size_t input_size, CompressorType comp,
int destlen = compressed->size(); int destlen = compressed->size();
destlen = LZ4_compress_default(input, string_as_array(compressed), destlen = LZ4_compress_default(input, string_as_array(compressed),
input_size, destlen); input_size, destlen);
CHECK(destlen != 0); CHECK_NE(destlen, 0);
if (!compressed_is_preallocated) { if (!compressed_is_preallocated) {
compressed->resize(destlen); compressed->resize(destlen);
} }
@@ -233,6 +233,8 @@ bool Compress(const char* input, size_t input_size, CompressorType comp,
bool Uncompress(const std::string& compressed, CompressorType comp, int size, bool Uncompress(const std::string& compressed, CompressorType comp, int size,
std::string* output) { std::string* output) {
// TODO: Switch to [[maybe_unused]] when we can assume C++17.
(void)size;
switch (comp) { switch (comp) {
#ifdef ZLIB_VERSION #ifdef ZLIB_VERSION
case ZLIB: { case ZLIB: {
@@ -272,7 +274,7 @@ bool Uncompress(const std::string& compressed, CompressorType comp, int size,
int destlen = output->size(); int destlen = output->size();
destlen = LZ4_decompress_safe(compressed.data(), string_as_array(output), destlen = LZ4_decompress_safe(compressed.data(), string_as_array(output),
compressed.size(), destlen); compressed.size(), destlen);
CHECK(destlen != 0); CHECK_NE(destlen, 0);
CHECK_EQ(size, destlen); CHECK_EQ(size, destlen);
break; break;
} }