fabi/Snappy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove inline qualifier from static variables.

Browse Source 
This feature requires C++17. Fortunately, inline is useful for header declarations, which may be included in multiple compilation units. The declarations modified by this CL occur in a single compilation unit.

PiperOrigin-RevId: 347338760
This commit is contained in:
Victor Costan
2020-12-14 09:38:48 +00:00
parent 3b571656fa
commit d1daa83044
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
snappy.cc
View File

@@ -260,8 +260,8 @@ MakePatternMaskBytesTable(int index_offset,
// This is an array of shuffle control masks that can be used as the source // This is an array of shuffle control masks that can be used as the source
// operand for PSHUFB to permute the contents of the destination XMM register // operand for PSHUFB to permute the contents of the destination XMM register
// into a repeating byte pattern. // into a repeating byte pattern.
alignas(16) inline constexpr std::array<std::array<char, sizeof(__m128i)>, alignas(16) constexpr std::array<std::array<char, sizeof(__m128i)>,
16> pattern_generation_masks = 16> pattern_generation_masks =
MakePatternMaskBytesTable( MakePatternMaskBytesTable(
/*index_offset=*/0, /*index_offset=*/0,
/*pattern_sizes_minus_one=*/make_index_sequence<16>()); /*pattern_sizes_minus_one=*/make_index_sequence<16>());
@@ -271,8 +271,8 @@ alignas(16) inline constexpr std::array<std::array<char, sizeof(__m128i)>,
// Basically, pattern_reshuffle_masks is a continuation of // Basically, pattern_reshuffle_masks is a continuation of
// pattern_generation_masks. It follows that, pattern_reshuffle_masks is same as // pattern_generation_masks. It follows that, pattern_reshuffle_masks is same as
// pattern_generation_masks for offsets 1, 2, 4, 8 and 16. // pattern_generation_masks for offsets 1, 2, 4, 8 and 16.
alignas(16) inline constexpr std::array<std::array<char, sizeof(__m128i)>, alignas(16) constexpr std::array<std::array<char, sizeof(__m128i)>,
16> pattern_reshuffle_masks = 16> pattern_reshuffle_masks =
MakePatternMaskBytesTable( MakePatternMaskBytesTable(
/*index_offset=*/16, /*index_offset=*/16,
/*pattern_sizes_minus_one=*/make_index_sequence<16>()); /*pattern_sizes_minus_one=*/make_index_sequence<16>());