port: the refuted 24-unit constant was living in a default; make it loud instead
ScreenView.exit_ramp_units defaulted to 24.0 -- the constant HANDOFF ask 2 told this port to author and that it refused, since the file's own ramp is 10 units. The authored entry was deleted as progress when the corrected record layout removed the unknown, and the default plus boot.gd's timing.get(..., 24.0) made that deletion a no-op. Both use sites are unreachable on today's export (866 keyframes, 0 untimed), so the branch is kept for an older export but no longer invents: the default is -1.0 meaning not supplied, and an untimed group now raises an error naming the screen rather than fabricating a duration. My first verification accused the change: main_menu 641941 px and extras 226009 px changed, on a branch that cannot execute and with no error raised. The cause was --screen=X --capture= firing at an uncontrolled instant -- t=9.00 in the earlier run against t=8.00 in the later one, one unit apart mid-build-in. Three runs now are byte-identical, so it is not noise; the instant is stable within a session and moves between them. Re-run with --time=1.0 pinned, old against new is byte-identical on all four screens. Records the harness limitation: --screen=X --capture= cannot be used for before/after comparison on an unsettled screen, which also explains the earlier settle-vs-rest confound. Also corrects my overstatement that other tools call the CLI -- verify-screen is the only one, checked. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N7FiFFFwbvG2uxdcEh8HyF
This commit is contained in:
@@ -200,7 +200,12 @@ func _ready() -> void:
|
||||
# give a synthetic time to. The default below is now unreachable rather than
|
||||
# authored, and both of ScreenView's uses are dead branches kept only so an
|
||||
# older export still loads.
|
||||
view.exit_ramp_units = float(timing.get("exit_ramp_units", 24.0))
|
||||
# ⚠️ The fallback is -1.0, NOT 24.0. It was 24.0 -- the constant HANDOFF ask 2
|
||||
# told this port to author and that it refused -- so deleting the authored
|
||||
# entry as progress silently reinstated the refuted number as a default.
|
||||
# Negative means "not supplied": ScreenView then declines to invent a duration
|
||||
# and says so, rather than making one up. See ScreenView.exit_ramp_units.
|
||||
view.exit_ramp_units = float(timing.get("exit_ramp_units", -1.0))
|
||||
_black_hold = float(timing.get("black_hold_units", 0.0))
|
||||
# Which focus records draw unconditionally and loop. Kept out of ScreenView's
|
||||
# own logic on purpose -- see `looping_focus` there for the census that says
|
||||
|
||||
Reference in New Issue
Block a user