From 1f23be9d13d68e835dc7c722edec4105fa4b4a32 Mon Sep 17 00:00:00 2001 From: Fabian Hamm Date: Mon, 14 Sep 2026 20:50:44 +0200 Subject: [PATCH] docs(agents): the zq.py database path is fixed, not outstanding MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This page recorded it as "not changed here, because the right replacement is a decision". The decision was taken: PR #35 `38cc170` resolves `$SYLPH_XEXDB`, then `/sylpheed.db`, then refuses with both named — no third fallback, because the database is an untracked build artefact and a default that silently resolves to the wrong one is worse than no default. Leaving the page saying otherwise would be the defect this section is about. `SCHEMA.md`'s retired-repo heading is still outstanding and stays listed. Co-Authored-By: Claude Opus 5 --- docs/agents/CONSOLIDATION.md | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/agents/CONSOLIDATION.md b/docs/agents/CONSOLIDATION.md index 953aa0c1..042ba3b0 100644 --- a/docs/agents/CONSOLIDATION.md +++ b/docs/agents/CONSOLIDATION.md @@ -317,13 +317,18 @@ it, since DuckDB's UPDATE is delete+insert and one inbound FK would make ### Phase 3 residue found while porting -* 🔴 **`tools/zq.py:48` hardcodes `/home/fabi/RE - Project Sylpheed/xenia-rs/sylpheed.db`** - — a default path *inside the repository Phase 5 archives and Phase 7 drops*. - Not changed here, because the right replacement is a decision (env var, - workspace-relative, or required argument) rather than a guess. -* `tools/zq.py:52` still tells the user to regenerate with `xenia-rs dis`, the - retired binary. `SCHEMA.md` is still headed *"`xenia-analysis` schema - reference"* and cites `xenia-rs dis --db`. +* ✅ **`tools/zq.py` hardcoded `/home/fabi/…/xenia-rs/sylpheed.db`** — a default + path *inside the repository Phase 5 archives and Phase 7 drops*, resolving on + exactly one machine and days from becoming a `duckdb` exception with nothing + saying why. **Fixed in PR #35 (`38cc170`):** `$SYLPH_XEXDB` → `/sylpheed.db` → a refusal naming both, with the repo-root path taken + relative to the *script* rather than the caller's cwd. **No fallback beyond + that, deliberately** — the database is an untracked build artefact of a few + hundred MB, so there is nothing to fall back *to*, and a default that silently + resolves to the wrong database is worse than no default. Same shape as #16. + The stale `xenia-rs dis` regeneration hint is now `sylph-xexdb dis`. +* `SCHEMA.md` is still headed *"`xenia-analysis` schema reference"* and cites + `xenia-rs dis --db` — the retired repo and binary. Not fixed. * Phase 3's "says SQLite, is DuckDB" correction **was** made where it counts (README and the binary's module doc both say DuckDB), but two inline comments at `sylph-xexdb.rs:499` and `:874` still say SQLite.