fix(decoder): give the container the Canary it is supposed to run
The database mount below was one of three ways the decoder could not reach its own oracle. The other two are here. `run-canary` never looked in `Checked/`. It tried `Release/` then `Debug/`, and both of those exist on this box -- an Aug 28 binary and a Jul 19 one. They boot the game perfectly well and carry NO `audit_61` branch probe, so a probe run against either returns zero hits that read as a finding about the game rather than as a stale binary. Configuration is now the outer loop and location the inner one, so a `Checked` build anywhere beats a `Release` build anywhere; `$XENIA_BIN` still overrides everything. Measured here: `Checked` has `audit_61_branch_probe_pcs`, `Release` and `Debug` do not. The launcher also now says which instrumentation is missing BEFORE the run, because the alternative is reading an empty log afterwards and guessing. `build-canary` built `$PROJECT_DIR/xenia-canary`, which does not exist in this container -- the source is bind-mounted at `/canary` and the launcher already exports `XENIA_SRC=/canary`. CONTAINER-NOTES has carried that defect since 2026-08-29 with a symlink workaround and a warning to remember to delete the symlink afterwards. It now reads `$XENIA_SRC` first, so there is nothing to remember. Its default configuration moves Release -> Checked to match what `run-canary` picks; the old default spent a full build on a binary nothing ran. Two documented blockers are refuted rather than deleted, since the sequence of wrong readings is what makes the right one checkable: the CONTAINER-NOTES symlink dance (the warm build volume it was configured against is gone too, removed in the 2026-09-18 cleanup, so the next build configures cleanly against `/canary`), and `upstream-baseline.md`'s "`version.h` is never generated" -- `CMakeLists.txt` generates it at configure time now, with a stub fallback. `decoder-loop.md` claimed the oracle was at `Linux/Release/` and that the probe was on two side branches; both were true when written and neither is now. Verified: five pick_bin cases against the extracted function body, and `strings` on all three real binaries. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -19,12 +19,13 @@ The instrumented branch stops at the Stage 02 briefing under a storm of
|
||||
behind `upstream/canary_experimental` (`a5a18f5c7`); our branch carries 50 of its
|
||||
own.
|
||||
|
||||
* **`version.h` is never generated.** The build fails on
|
||||
`trace_writer.cc:17: fatal error: 'version.h' file not found`. Upstream's
|
||||
`xenia-build.py` writes it from git HEAD; the container's `build-canary`
|
||||
wrapper does not invoke it, and our tree only builds because a stale copy from
|
||||
an old `sylpheed-re` build sits in the build directory. Regenerated by hand in
|
||||
exactly the format that script emits.
|
||||
* ~~**`version.h` is never generated.**~~ ✅ **FIXED — `CMakeLists.txt` now
|
||||
generates it at configure time**, calling `xenia-build.py`'s
|
||||
`generate_version_h()` and falling back to a stub if that fails, so a
|
||||
CMake-direct build no longer depends on a stale copy in the build directory.
|
||||
It used to fail on `trace_writer.cc:17: fatal error: 'version.h' file not
|
||||
found`, and the fix had to exist before the 2026-09-18 cleanup deleted the
|
||||
build volume that was carrying that stale copy.
|
||||
* **`build-canary` reports success on a failed build.** The harness recorded
|
||||
"completed (exit code 0)" while ninja had stopped with `1 error generated`.
|
||||
Only the missing binary gave it away.
|
||||
|
||||
Reference in New Issue
Block a user