From 2d2caccd758d45934a364909dd9e54f88bbd8233 Mon Sep 17 00:00:00 2001 From: Sylpheed port agent Date: Wed, 2 Sep 2026 21:12:05 +0000 Subject: [PATCH] port: check-citations gave a FALSE RED on a freshly pushed peer file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A citation added minutes after the other agent pushed the file it names resolved NOWHERE, because this scans local refs and the local ref was stale. The citation was right and the check was wrong. It now says so in the failure text and tells the reader to fetch before editing. A check that cries wolf is worse than no check -- and this one had just been teaching me to distrust a correct citation. šŸ”“ Separately, my own slip: I ran this as '; git commit' instead of ' && git commit', so the commit landed while the check was red. The guard was in the command and I had disabled it by punctuation. --- tools/port/check-citations | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/port/check-citations b/tools/port/check-citations index 53c824b3..8fd2a9a3 100755 --- a/tools/port/check-citations +++ b/tools/port/check-citations @@ -97,6 +97,13 @@ def main() -> int: for m, src in sorted(nowhere.items()): print(" %-52s <- %s" % (m, os.path.basename(src))) print("\nšŸ”“ a reader following those gets nothing. Fix the path or drop the citation.") + # šŸ”“ FALSE RED, HIT 2026-09-02: a peer-branch file cited minutes after it + # was pushed resolves NOWHERE here, because this scans local refs and the + # local ref was stale. The citation was correct and the check was wrong. + # A check that cries wolf is worse than no check, so it now says so. + print(" āš ļø If a path was pushed by the other agent recently, this may be") + print(" a STALE LOCAL REF rather than a bad citation. Run") + print(" `git fetch origin` and re-run before editing anything.") return 1 print(" šŸ”“ resolve nowhere : 0") return 0