fabi/Sylpheed
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

port: put verify-menu-audio's control in check-all

Browse Source 
Every other assertion in check-all has a control; audio was the one that did
not, which is how it went weeks unable to fail. Control measured just now: with
move absent from the baseline the diagonal reads +0.000, the check reports 'at
least one cue is not sounding' and exits 1.
This commit is contained in:
Sylpheed port agent
2026-09-02 16:40:55 +00:00
parent 937f05595c
commit 77320d5e41
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/port/check-all
View File

@@ -117,6 +117,12 @@ step transcode-bands must-pass tools/port/verify-transcode-fidelity
step bands-harness must-pass tools/port/verify-transcode-fidelity --selftest step bands-harness must-pass tools/port/verify-transcode-fidelity --selftest
step capture-controls must-pass tools/port/check-capture-controls step capture-controls must-pass tools/port/check-capture-controls
step menu-audio must-pass env OUT="$OUT/audio" tools/port/verify-menu-audio step menu-audio must-pass env OUT="$OUT/audio" tools/port/verify-menu-audio
# 🔴 ADDED 2026-09-02, because `menu-audio` above SPENT WEEKS UNABLE TO FAIL. It
# computed its verdict, printed a red line when a cue was silent, and its python
# had no exit path -- so it returned 0 while registered `must-pass` here. Every
# other assertion in this file has a control for exactly this reason and audio
# was the one that did not. It costs a second set of runs and that is the price.
step menu-audio-ctl must-pass env OUT="$OUT/audioctl" tools/port/verify-menu-audio --control
# 🔴 ADDED 2026-09-01 after a human found Ⓐ dead on a real controller while the # 🔴 ADDED 2026-09-01 after a human found Ⓐ dead on a real controller while the
# unattended P5 walk passed. `--script` sends `InputEventAction`, which BYPASSES # unattended P5 walk passed. `--script` sends `InputEventAction`, which BYPASSES
# the input map, so every check here asserted the code BELOW the map and nothing # the input map, so every check here asserted the code BELOW the map and nothing