feat(port): adopt the measured held-direction repeat rate (F1)
REPEAT_DELAY = 0.402, REPEAT_INTERVAL = 0.134, from docs/re/f1-repeat-measured-via-driver-patch.md -- 12 and 4 frames at the run's achieved 29.87 fps guest rate, converted to seconds because this port does not run at the guest's rate and it is the cadence that was measured. The mechanism has been here since 2026-09-02 and inert on purpose. The instruction it was waiting on is now vindicated in the most awkward way: the draft it refused to ship had 0.40 / 0.20, so the guessed delay was nearly right and the guessed interval was off by 50 %. The half that was wrong would have been protected by the half that was right. The delay and the interval are NOT equally well evidenced, and the code says so at the constants. No physical controller exists in the Decoder's container, so the measurement fed Canary's file driver the SDL driver's own 400/100 ms constants: the 402 ms that came back is the constant that went in, and confirms the instrument. The 133 ms interval against a fed-in 100 ms is the new fact -- the game paces repeats to its own frame consumption. One run; the two-run minimum is not met and the finding says so itself. Also: the prediction that this would turn verify-input's "a held stick is ONE step, not six" red was wrong. It stayed green, because steps() never advances a clock and so had never called repeat_due() at all -- the rate was about to ship into a harness with no coverage of the feature, with a green line that would have been read as coverage. So verify-input gains a `repeat` subject: nothing before the delay, the first repeat on the delay, the steady interval, cadence independent of frame rate (the code claims this in a comment, so it is now asserted), and a direction change restarting the delay. Each asserts THESE numbers, not the shape -- a shape-only check would have passed on 0.40 / 0.20. The control removes the premise, a held direction, and every controllable row inverts. The first-repeat row measures from the arming tick, not from t=0: that tick is the frame the press is handled, which is the origin the finding measures its 12 frames from. Measured from zero it read 0.433 vs 0.402 and the tolerance would have had to be widened to hide a units mismatch. Closes #2 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,7 +1,10 @@
|
||||
# F1 — the menu repeats on a held direction: mechanism shipped, **rate deliberately not**
|
||||
# F1 — the menu repeats on a held direction: mechanism shipped, **and the rate adopted**
|
||||
|
||||
**Status:** ✅ mechanism implemented and wired. 🔴 **inert on purpose** — it does
|
||||
nothing until a measured repeat rate exists. Written 2026-09-02 by the Port.
|
||||
**Status:** ✅ mechanism implemented and wired, 2026-09-02. ✅ **rate adopted
|
||||
2026-09-13** from `docs/re/f1-repeat-measured-via-driver-patch.md` —
|
||||
`REPEAT_DELAY = 0.402`, `REPEAT_INTERVAL = 0.134`. It ran inert for eleven days
|
||||
and that was the right state; this page keeps the inert-era reasoning because it
|
||||
is why the two numbers can be trusted now.
|
||||
|
||||
## What was reported
|
||||
|
||||
@@ -57,42 +60,87 @@ A repeat that could fire during a movie or mid-transition would be a **second,
|
||||
subtly different input path**, and the first thing this port learned about input
|
||||
is that a second path is where the defect hides.
|
||||
|
||||
## 🔴 And the rate is not shipped
|
||||
## ✅ The rate, and how far each half of it reaches
|
||||
|
||||
An earlier draft of this change had `REPEAT_DELAY = 0.40` and
|
||||
`REPEAT_INTERVAL = 0.20`, with a paragraph explaining that they were authored.
|
||||
**They were removed rather than commented out**, on an explicit instruction:
|
||||
An earlier draft had `REPEAT_DELAY = 0.40` and `REPEAT_INTERVAL = 0.20` with a
|
||||
paragraph explaining that they were authored. They were removed rather than
|
||||
commented out, on an explicit instruction:
|
||||
|
||||
> *"Take the RATE from the Decoder — do NOT ship a placeholder interval. An
|
||||
> invented rate here is indistinguishable from a measured one later, and this is
|
||||
> the exact field where that already cost us."*
|
||||
|
||||
The instruction is right and the draft was the named failure mode: the
|
||||
explanation would have merged, the numbers would have felt roughly right, and
|
||||
nothing downstream could have separated them from a measurement. `REPEAT_DELAY`
|
||||
is `-1.0`; `repeat_due()` returns 0 while `repeat_rate_known()` is false.
|
||||
📌 **The measurement has now landed, and it vindicates the instruction in the
|
||||
most awkward possible way: the guessed delay was nearly right and the guessed
|
||||
interval was off by 50 %.** 0.40 against a measured 0.402; 0.20 against a
|
||||
measured 0.134. Had both shipped, the half that was wrong would have been
|
||||
protected by the half that was right.
|
||||
|
||||
**One thing about the rate IS measured, and it narrows the question.** The game
|
||||
digitises the left stick to four direction bits at 61 % deflection, so it cannot
|
||||
see deflection magnitude at all — the repeat it drives *cannot* be
|
||||
faster-the-harder-you-push. That excludes the one competing model, so only two
|
||||
constants are open and a single measurement closes both.
|
||||
The Decoder measured, in Canary at an achieved 29.87 fps guest rate, **12 frames**
|
||||
from the press-triggered step to the first repeat and **4 frames** per step after
|
||||
it. Converted to seconds here because this port does not run at the guest's rate
|
||||
and it is the cadence that was measured: 12 / 29.87 = **0.402**, 4 / 29.87 =
|
||||
**0.134**.
|
||||
|
||||
## ⚠️ Adopting the rate breaks a green check, for the right reason
|
||||
### ⚠️ The two numbers are not equally well evidenced
|
||||
|
||||
`tools/port/verify-input` asserts *"a held stick is ONE step, not six"*. That row
|
||||
passes today **because the feature is inert**, i.e. it asserts the absence of the
|
||||
repeat. When a rate is adopted a held stick should produce further steps and that
|
||||
row will go red.
|
||||
No physical controller exists in the Decoder's container. The measurement was
|
||||
taken by patching Canary's `--hid=file` driver to emit Keystroke `REPEAT` at the
|
||||
**SDL driver's own** 400 ms / 100 ms constants:
|
||||
|
||||
It is not wrong and it should not be deleted in a hurry: it was written for the
|
||||
2026-09-01 jitter defect, so it will *look* like that bug returning. It has to be
|
||||
re-stated as "one step per deflection **plus** the measured repeat", with the
|
||||
jitter case still covered inside the delay window.
|
||||
* the **delay** came back as 402 ms — to within the frame quantum, *the constant
|
||||
that was fed in*. It confirms the instrument, not the game;
|
||||
* the **interval** came back as 133 ms against a fed-in 100 ms. That gap is the
|
||||
genuinely new fact: the game paces repeats to its own frame consumption rather
|
||||
than to the event stream.
|
||||
|
||||
So the interval is what the game does; the delay is what Xenia's SDL driver does,
|
||||
and the game was not observed to disagree. **One run** — the corpus's own two-run
|
||||
minimum is not met, and the source page says so itself.
|
||||
|
||||
**One thing about the rate was already measured, and it narrowed the question.**
|
||||
The game digitises the left stick to four direction bits at 61 % deflection, so
|
||||
it cannot see deflection magnitude at all — the repeat it drives *cannot* be
|
||||
faster-the-harder-you-push. That excluded the one competing model, so only two
|
||||
constants were ever open and a single measurement closed both.
|
||||
|
||||
## 🔴 Adopting the rate was predicted to break a green check. It did not, and that was worse
|
||||
|
||||
This page and `gamepad.gd` both said that `verify-input`'s row *"a held stick is
|
||||
ONE step, not six"* asserts the **absence** of the repeat, and would go red on
|
||||
adoption — looking like the 2026-09-01 jitter defect returning.
|
||||
|
||||
**Run on adoption day: the row stayed green.** `steps()` feeds axis values through
|
||||
the latch and never advances a clock, so it had never called `repeat_due()` at
|
||||
all. The row tests the *latch*, which the repeat does not touch. The prediction
|
||||
was reasoned rather than run.
|
||||
|
||||
What it hid is the real problem: the rate was about to ship into a harness with
|
||||
**no coverage of this feature whatsoever**, and that green line would have been
|
||||
read as coverage of it.
|
||||
|
||||
The fix was not to change that row. `verify-input` gains a `repeat` subject that
|
||||
holds a direction through the same latch and ticks `repeat_due()`, asserting
|
||||
**these two numbers** — a shape-only check ("it repeats eventually") would have
|
||||
passed on the 0.40 / 0.20 guess this port refused to ship. Five rows: nothing
|
||||
before the delay, the first repeat on the delay, the steady interval, cadence
|
||||
independent of frame rate (the code claims this in a comment, so it is asserted),
|
||||
and a direction change restarting the delay.
|
||||
|
||||
⚠️ **The origin is one frame, and it is not a tolerance.** `repeat_due()`'s first
|
||||
call only latches the direction; the clock accumulates from the call after it. In
|
||||
the port that first call is the frame the press is handled — the frame that
|
||||
produced the press-triggered step — which is the origin the finding measures its
|
||||
12 frames from. Measured from `t = 0` the harness read 0.433 against 0.402 and
|
||||
the tolerance would have had to be widened to hide a units mismatch.
|
||||
|
||||
## What this does not claim
|
||||
|
||||
* That the repeat feels right. It cannot — it does not run.
|
||||
* That the repeat feels right. It runs now, and **only a human can answer that**:
|
||||
0.134 s is ~7.5 steps a second, and the play-test that opened this asked for
|
||||
*"slow enough to see which item is selected"*. If it reads as too fast, the
|
||||
100 ms constant is Xenia's and not the game's, and no capture in that
|
||||
container would have revealed it.
|
||||
* Any rate, or any bound on one. "Medium pace" is a direction, not a number, and
|
||||
it is not recorded anywhere as data.
|
||||
* That the d-pad and the stick repeat at the *same* rate. Both repeat; nobody
|
||||
|
||||
Reference in New Issue
Block a user