fabi/Sylpheed
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

port: sweep the tree for values a deleted entry still supplies -- one instance, already fixed

Browse Source 
The exit_ramp_units catch generalises: deleting an authored value does not remove
it if something supplies it silently, and authored/ is where a reader looks and
does not find it. Swept both halves of what I own.

GDScript: every keyed lookup with a fallback, cross-checked against the 121 keys
present in authored/. One hit -- exit_ramp_units, the case already fixed -- which
makes it the sweep's own positive control: the detector found the known instance
and nothing else. The other numeric fallbacks are identity or sentinel and invent
no quantity.

Exporter: 14 serde(default) sites, all attaching to Option, Vec or map types,
where an absent key becomes None or empty and asserts nothing.

My classifier produced a false positive I nearly wrote up: it flagged
also_export: AlsoExport as a semantic default because the type name lacks a
container prefix. AlsoExport is a type alias for a BTreeMap. Classifying a type by
the spelling of its name is the same proxy reasoning as inferring an era from a
line count.

Negative result, but from a check that demonstrably finds the known case.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N7FiFFFwbvG2uxdcEh8HyF
This commit is contained in:
Sylpheed port agent
2026-08-30 14:59:37 +00:00
parent 0be8348a6f
commit fe6e4a384a
1 changed files with 47 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
docs/port/DECISIONS.md
View File

@@ -9,7 +9,7 @@ dies, which is what this file is for.
<!-- INDEX: generated by tools/port/index-decisions -- do not hand-edit -->
170 sections. Search this before re-deriving anything.
171 sections. Search this before re-deriving anything.
* [P0 — the exporter, 2026-08-28](#p0--the-exporter-2026-08-28)
* [P1 — Godot draws the screen, 2026-08-28](#p1--godot-draws-the-screen-2026-08-28)
@@ -181,6 +181,7 @@ dies, which is what this file is for.
* [🔴 CORRECTION: my "the eras render identically" measurement was void](#correction-my-the-eras-render-identically-measurement-was-void)
* [🔴 CORRECTION: my branch *is* the stale era, and the reference binary was never the workspace build](#correction-my-branch-is-the-stale-era-and-the-reference-binary-was-never-the-workspace-build)
* [`exit_ramp_units`: the refuted constant was living in a default](#exit_ramp_units-the-refuted-constant-was-living-in-a-default)
* [Auditing the whole tree for "a deleted value that something still supplies"](#auditing-the-whole-tree-for-a-deleted-value-that-something-still-supplies)
<!-- /INDEX -->
## P0 — the exporter, 2026-08-28
@@ -9759,3 +9760,48 @@ Last iteration I said the era guard "closes that for `verify-screen` only, not f
the other tools that call the CLI". ✅ `verify-screen` is the **only** tool under
`tools/port/` that invokes `sylpheed-cli` — checked, not assumed. The guard covers
every caller there is.
## Auditing the whole tree for "a deleted value that something still supplies"
The `exit_ramp_units` catch generalises, in the Decoder's words: **deleting a value
does not remove it if something supplies it silently — and `authored/` is exactly
where a reader would look and not find it.** So I swept both halves of what I own
for the same shape rather than treating it as one bug.
### GDScript: every keyed lookup with a fallback
| key | default | in `authored/`? |
|---|---|---|
| `period_units`, `record_element` | `0.0`, `""` | ✅ |
| `black_hold_units` | `0.0` | ✅ |
| `looping_focus_records`, `draw_leaf_for`, `loop_leaf_on_screens` | `{}`, `[]`, `[]` | ✅ |
| `ramp` | `"linear"` | ✅ |
| **`exit_ramp_units`** | **`-1.0`** | **🔴 not in `authored/`** |
✅ **One hit, and it is the one already fixed** — which makes it the sweep's own
positive control: the detector found the known instance and nothing else. Its
default is now `-1.0` meaning *not supplied*, which is deliberate and documented
rather than a silent value.
The other numeric fallbacks in `screen_view.gd` are identity or sentinel —
`rotation_deg → 0` is *no rotation*, `period_units → 0.0` is *no loop* and is
guarded by `> 0.0`, `index → -1` is a sentinel. None of them invents a quantity.
### The exporter: `serde(default)` does the same thing in Rust
14 sites. All but one attach to `Option<T>`, a `Vec` or a map — absent key becomes
`None`/empty, which asserts nothing.
⚠️ **My classifier produced a false positive and I nearly wrote it up.** It flagged
`also_export: AlsoExport` as a semantic default because the type name does not
start with a container prefix. `AlsoExport` is a **type alias for a `BTreeMap`**;
its default is an empty map. Classifying a type by the spelling of its name is the
same proxy reasoning as inferring an era from a line count — I caught it by
opening the definition, which took thirty seconds and is the whole difference.
### Result
✅ **Nothing new.** One instance across the port and the exporter, already fixed.
That is worth recording precisely because a negative result from a check that
demonstrably finds the known case is evidence, where "I looked and it seemed fine"
is not.