chore: retire the last dead paths and names from the consolidation #47

fabi · 2026-09-16T20:35:25Z

fabi commented

2026-09-16 20:35:25 +00:00

Last consolidation cleanup: dead paths, retired names, and the plan's own status. This changes where tools look for data, not what they compute.

Code and tools

tools/re-capture censuses read the disc from $SYLPHEED_DISC. 33 scripts globbed /work/sylph_extract, a path that has existed nowhere since /work became a clone. A glob over a missing directory matches nothing, so they printed empty results instead of failing (the #44 finding, now fixed everywhere). They now go through a new disc.py, which exits with a message when the variable is missing. unitgroup.py only needs it when --pak isn't given.
Sibling imports. Nine scripts imported helpers from the retired Reborn checkout, an old session scratchpad, or /work/tools. They now import from their own directory, where those modules live.
sylpheed-xex only needs the XEX2 retail key. The dead devkit key constant is gone, and so is a doc comment claiming a devkit fallback that doesn't exist. Project Sylpheed is a retail XEX2, so no XEX1 key is needed either.
sylpheed-viewer: real_font_rasterizes actually runs now. It looked for /tmp/sylph_extract and so always skipped. It now reads $SYLPHEED_DISC.
Smaller fixes: the decode_table_check usage line (-p sylpheed-ppc), the golden-fixture path in disasm_goldens.rs, extract_movie_subtitles.py's hard-coded disc, and one stale sentence in zq.py.

Docs

docs/re pages that told the reader to use xenia-rs/sylpheed.db, xenia-rs's context layout or /work/*.pe now name sylpheed.db + tools/zq.py, Canary's ppc_context.h and the flat .pe. Findings keep their original provenance: a result measured against /work/xenia-rs/sylpheed.db still says so.
docs/re/README.md no longer says the native Canary build doesn't run. It lists both builds and their launchers.
docs/port/AUDIO-VERIFICATION.md: a link into the archived Reborn repository now points at the same page in this one.
docs/agents/CONSOLIDATION.md is closed. Phases 5 and 7 are marked done, with the verified end state at the top, and the retention question and history rewrite are left open for you.

Container and agent material (docker/decoder, docker/port, the port-loop mission docs, the capture shell harness) is untouched, as asked.

Checked

All touched Python compiles, and no /work/sylph_extract remains in code; the only hits are two comments recording the old bug.
Run against the extracted disc, these scripts produce output: unitgroup.py --check (S02: 111/111), stagetbl.py, mission_scoring.py, preset_messages.py, sound_cues.py and bgm_wave_census.py (32 banks). Without $SYLPHEED_DISC, stagetbl.py exits 1 with the message, and unitgroup.py still works when given --pak.
cargo test -p sylpheed-viewer --lib real_font_rasterizes in docker/ci/run with the disc mounted: 1 passed. Before this change it self-skipped on every machine.
rustfmt --check reports nothing in the edited Rust.

🤖 Generated with Claude Code

Last consolidation cleanup: dead paths, retired names, and the plan's own status. This changes where tools look for data, not what they compute. ## Code and tools - **`tools/re-capture` censuses read the disc from `$SYLPHEED_DISC`.** 33 scripts globbed `/work/sylph_extract`, a path that has existed nowhere since `/work` became a clone. A glob over a missing directory matches nothing, so they printed empty results instead of failing (the #44 finding, now fixed everywhere). They now go through a new `disc.py`, which exits with a message when the variable is missing. `unitgroup.py` only needs it when `--pak` isn't given. - **Sibling imports.** Nine scripts imported helpers from the retired Reborn checkout, an old session scratchpad, or `/work/tools`. They now import from their own directory, where those modules live. - **`sylpheed-xex` only needs the XEX2 retail key.** The dead devkit key constant is gone, and so is a doc comment claiming a devkit fallback that doesn't exist. Project Sylpheed is a retail XEX2, so no XEX1 key is needed either. - **`sylpheed-viewer`: `real_font_rasterizes` actually runs now.** It looked for `/tmp/sylph_extract` and so always skipped. It now reads `$SYLPHEED_DISC`. - Smaller fixes: the `decode_table_check` usage line (`-p sylpheed-ppc`), the golden-fixture path in `disasm_goldens.rs`, `extract_movie_subtitles.py`'s hard-coded disc, and one stale sentence in `zq.py`. ## Docs - `docs/re` pages that told the reader to use `xenia-rs/sylpheed.db`, xenia-rs's context layout or `/work/*.pe` now name `sylpheed.db` + `tools/zq.py`, Canary's `ppc_context.h` and the flat `.pe`. Findings keep their original provenance: a result measured against `/work/xenia-rs/sylpheed.db` still says so. - `docs/re/README.md` no longer says the native Canary build doesn't run. It lists both builds and their launchers. - `docs/port/AUDIO-VERIFICATION.md`: a link into the archived Reborn repository now points at the same page in this one. - `docs/agents/CONSOLIDATION.md` is closed. Phases 5 and 7 are marked done, with the verified end state at the top, and the retention question and history rewrite are left open for you. Container and agent material (`docker/decoder`, `docker/port`, the port-loop mission docs, the capture shell harness) is untouched, as asked. ## Checked - All touched Python compiles, and no `/work/sylph_extract` remains in code; the only hits are two comments recording the old bug. - Run against the extracted disc, these scripts produce output: `unitgroup.py --check` (S02: 111/111), `stagetbl.py`, `mission_scoring.py`, `preset_messages.py`, `sound_cues.py` and `bgm_wave_census.py` (32 banks). Without `$SYLPHEED_DISC`, `stagetbl.py` exits 1 with the message, and `unitgroup.py` still works when given `--pak`. - `cargo test -p sylpheed-viewer --lib real_font_rasterizes` in `docker/ci/run` with the disc mounted: **1 passed**. Before this change it self-skipped on every machine. - `rustfmt --check` reports nothing in the edited Rust. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

fabi added 2 commits 2026-09-16 20:35:28 +00:00

chore: retire the last dead paths and names from the consolidation ac0ad579fd

Nothing here changes what a tool computes; it changes where tools look.

- tools/re-capture: 33 censuses globbed /work/sylph_extract, a path that has
  existed nowhere since /work became a clone, so they matched nothing and
  printed empty results. They now resolve the disc through a new disc.py
  from $SYLPHEED_DISC and exit loudly without it (the #44 fix, generalised).
  Nine scripts that imported siblings from the retired Reborn checkout or an
  old session scratchpad now import from their own directory. unitgroup.py
  only needs the variable when --pak is not given.
- sylpheed-xex: the loader only ever uses the XEX2 retail key. The dead
  devkit key and a doc comment claiming a devkit fallback that does not
  exist are gone; Project Sylpheed is a retail XEX2, so no XEX1 key either.
- sylpheed-viewer: real_font_rasterizes looked for /tmp/sylph_extract and so
  always skipped. It reads $SYLPHEED_DISC now, and passes against the disc.
- Comments and docs that named xenia-rs, the Reborn repository or /work/*.pe
  as places to look now name sylpheed.db, Canary's ppc_context.h and the
  flat .pe; docs/re/README.md no longer says the native Canary build does not
  run.

Historical records keep their original paths: findings that were measured
against /work/xenia-rs/sylpheed.db still say so.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

docs(consolidation): close the plan — phases 5 and 7 are done

CI / Native — linux (pull_request) Successful in 2h0m9s

Details

CI / WASM — Web (pull_request) Successful in 28m8s

Details

CI / Formatting (pull_request) Successful in 1m6s

Details

68439633d8

Record the end state at the top of the page: four repositories archived, their
clones gone from this machine, the Phase 7 drops done or never present here, and
Canary's default branch moved off `xenia-rs`. The retention question and the
history rewrite stay open for the human.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

fabi added 1 commit 2026-09-16 20:38:10 +00:00

docs(consolidation): record that the devkit and XEX1 keys are not needed

CI / Native — linux (pull_request) Successful in 2h5m5s

Details

CI / WASM — Web (pull_request) Successful in 28m21s

Details

CI / Formatting (pull_request) Successful in 1m14s

Details

8ea4cf86ab

Project Sylpheed ships as a retail XEX2 (human decision, 2026-09-16), so
Phase 2's key harvest is closed rather than left looking unfinished.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

fabi merged commit 2d0443ed1b into main

2026-09-17 05:11:37 +00:00

fabi referenced this issue from a commit

2026-09-17 05:11:38 +00:00

Merge pull request 'chore: retire the last dead paths and names from the consolidation' (#47) from chore/retire-leftover-names into main

fabi referenced this issue from a commit

2026-09-19 20:29:49 +00:00

Merge pull request 'chore: retire the last dead paths and names from the consolidation' (#47) from chore/retire-leftover-names into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fabi/Sylpheed#47