The cause, and the fix, with a disc-wide check. resolve_movie_voice_region picks start = the predecessor cue's trailer, then filtered it with 'end - s < 1_500_000' -- 'only within one bank'. ADV's predecessor sits 3 618 816 B before end, so the filter rejected it and start fell back to anchor, which is a TOC offset and not a stream boundary. That explains the shape of the defect exactly: it strikes regions larger than 1.5 MB, which is why the three-stream multichannel regions are hit and single-stream ones never are. 17 of 95 resolving movies took the fallback. ADV's predecessor trailer at 433 425 776 plus 17 040 B of descriptor and padding is 433 442 816 -- the -238-packet start measured against the decoder, to the byte. Dropping the cap: unchanged 78, fixed cleanly 17, changed in any other way ZERO. In all 17 the only difference is a larger first chunk with every later chunk byte-identical, which is what a corrected start looks like and what pulling in a neighbouring asset does not. Regression test pinned to the RUNNING DECODER's byte_sizes rather than to this crate's own output. That is the point of it: every internal check passed happily while a third of a stream was missing, so only an external number could have caught this class of bug. sylpheed-formats: 136 tests pass, 0 fail (the one still running at commit time is an unrelated long mesh test). Exact clips for the other 16 are not independently verified -- the sweep is strong but ADV is the only one with a decoder measurement behind it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wuu56cE8vJGTBtn1ppsk8v
37 lines
2.1 KiB
Plaintext
37 lines
2.1 KiB
Plaintext
ADV today [806912, 1118208, 1171456]
|
|
prop [1294336, 1118208, 1171456] first chunk GREW, tail identical
|
|
S00A today [1323008, 1263616, 98304]
|
|
prop [1810432, 1263616, 98304] first chunk GREW, tail identical
|
|
S01A today [1153024, 1390592, 1552384]
|
|
prop [1640448, 1390592, 1552384] first chunk GREW, tail identical
|
|
S02B today [430080, 505856, 866304]
|
|
prop [919552, 505856, 866304] first chunk GREW, tail identical
|
|
S02C today [1867776, 1349632, 2390016]
|
|
prop [2353152, 1349632, 2390016] first chunk GREW, tail identical
|
|
S03A today [251904, 540672, 739328]
|
|
prop [741376, 540672, 739328] first chunk GREW, tail identical
|
|
S04B today [555008, 870400, 991232]
|
|
prop [1044480, 870400, 991232] first chunk GREW, tail identical
|
|
S06A today [350208, 294912, 860160]
|
|
prop [839680, 294912, 860160] first chunk GREW, tail identical
|
|
S06B today [606208, 874496, 1449984]
|
|
prop [1093632, 874496, 1449984] first chunk GREW, tail identical
|
|
S07A today [503808, 473088, 1040384]
|
|
prop [993280, 473088, 1040384] first chunk GREW, tail identical
|
|
S09B today [176128, 571392, 843776]
|
|
prop [665600, 571392, 843776] first chunk GREW, tail identical
|
|
S11C today [741376, 1075200, 1107968]
|
|
prop [1228800, 1075200, 1107968] first chunk GREW, tail identical
|
|
S12C today [1843200, 1273856, 2502656]
|
|
prop [2328576, 1273856, 2502656] first chunk GREW, tail identical
|
|
S13A today [401408, 585728, 962560]
|
|
prop [890880, 585728, 962560] first chunk GREW, tail identical
|
|
S14A today [1816576, 1634304, 2541568]
|
|
prop [2301952, 1634304, 2541568] first chunk GREW, tail identical
|
|
S15A today [253952, 618496, 1122304]
|
|
prop [743424, 618496, 1122304] first chunk GREW, tail identical
|
|
S15C today [929792, 1101824, 1384448]
|
|
prop [1417216, 1101824, 1384448] first chunk GREW, tail identical
|
|
|
|
unchanged 78 fixed-cleanly 17 would-break 0 skipped 9
|