[Vulkan] Untextured ImmediateDrawer, [D3D12] Small refactoring

src/xenia/gpu/d3d12/d3d12_command_processor.h

@@ -376,7 +376,7 @@ class D3D12CommandProcessor : public CommandProcessor {
   CommandAllocator* command_allocator_submitted_last_ = nullptr;
   ID3D12GraphicsCommandList* command_list_ = nullptr;
   ID3D12GraphicsCommandList1* command_list_1_ = nullptr;
-  std::unique_ptr<DeferredCommandList> deferred_command_list_ = nullptr;
+  std::unique_ptr<DeferredCommandList> deferred_command_list_;
 
   // Should bindless textures and samplers be used - many times faster
   // UpdateBindings than bindful (that becomes a significant bottleneck with
@@ -388,14 +388,12 @@ class D3D12CommandProcessor : public CommandProcessor {
   // targets.
   bool edram_rov_used_ = false;
 
-  std::unique_ptr<ui::d3d12::D3D12UploadBufferPool> constant_buffer_pool_ =
-      nullptr;
+  std::unique_ptr<ui::d3d12::D3D12UploadBufferPool> constant_buffer_pool_;
 
   static constexpr uint32_t kViewBindfulHeapSize = 32768;
   static_assert(kViewBindfulHeapSize <=
                 D3D12_MAX_SHADER_VISIBLE_DESCRIPTOR_HEAP_SIZE_TIER_1);
-  std::unique_ptr<ui::d3d12::D3D12DescriptorHeapPool> view_bindful_heap_pool_ =
-      nullptr;
+  std::unique_ptr<ui::d3d12::D3D12DescriptorHeapPool> view_bindful_heap_pool_;
   // Currently bound descriptor heap - updated by RequestViewBindfulDescriptors.
   ID3D12DescriptorHeap* view_bindful_heap_current_;
   // Rationale: textures have 4 KB alignment in guest memory, and there can be
@@ -426,7 +424,7 @@ class D3D12CommandProcessor : public CommandProcessor {
   static constexpr uint32_t kSamplerHeapSize = 2000;
   static_assert(kSamplerHeapSize <= D3D12_MAX_SHADER_VISIBLE_SAMPLER_HEAP_SIZE);
   std::unique_ptr<ui::d3d12::D3D12DescriptorHeapPool>
-      sampler_bindful_heap_pool_ = nullptr;
+      sampler_bindful_heap_pool_;
   ID3D12DescriptorHeap* sampler_bindful_heap_current_;
   ID3D12DescriptorHeap* sampler_bindless_heap_current_ = nullptr;
   D3D12_CPU_DESCRIPTOR_HANDLE sampler_bindless_heap_cpu_start_;
@@ -452,15 +450,15 @@ class D3D12CommandProcessor : public CommandProcessor {
   ID3D12RootSignature* root_signature_bindless_vs_ = nullptr;
   ID3D12RootSignature* root_signature_bindless_ds_ = nullptr;
 
-  std::unique_ptr<SharedMemory> shared_memory_ = nullptr;
+  std::unique_ptr<SharedMemory> shared_memory_;
 
-  std::unique_ptr<PipelineCache> pipeline_cache_ = nullptr;
+  std::unique_ptr<PipelineCache> pipeline_cache_;
 
-  std::unique_ptr<TextureCache> texture_cache_ = nullptr;
+  std::unique_ptr<TextureCache> texture_cache_;
 
-  std::unique_ptr<RenderTargetCache> render_target_cache_ = nullptr;
+  std::unique_ptr<RenderTargetCache> render_target_cache_;
 
-  std::unique_ptr<PrimitiveConverter> primitive_converter_ = nullptr;
+  std::unique_ptr<PrimitiveConverter> primitive_converter_;
 
   // Mip 0 contains the normal gamma ramp (256 entries), mip 1 contains the PWL
   // ramp (128 entries). DXGI_FORMAT_R10G10B10A2_UNORM 1D.

src/xenia/gpu/d3d12/d3d12_graphics_system.cc

@@ -20,7 +20,7 @@ namespace xe {
 namespace gpu {
 namespace d3d12 {
 
-// Generated with `xb buildhlsl`.
+// Generated with `xb gendxbc`.
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/fullscreen_vs.h"
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/stretch_gamma_ps.h"
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/stretch_ps.h"

src/xenia/gpu/d3d12/pipeline_cache.cc

@@ -56,7 +56,7 @@ namespace xe {
 namespace gpu {
 namespace d3d12 {
 
-// Generated with `xb buildhlsl`.
+// Generated with `xb gendxbc`.
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/adaptive_quad_hs.h"
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/adaptive_triangle_hs.h"
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/continuous_quad_hs.h"

src/xenia/gpu/d3d12/pipeline_cache.h

@@ -247,7 +247,7 @@ class PipelineCache {
   uint32_t resolution_scale_;
 
   // Reusable shader translator.
-  std::unique_ptr<DxbcShaderTranslator> shader_translator_ = nullptr;
+  std::unique_ptr<DxbcShaderTranslator> shader_translator_;
 
   // Command processor thread DXIL conversion/disassembly interfaces, if DXIL
   // disassembly is enabled.
@@ -344,7 +344,7 @@ class PipelineCache {
   // Manual-reset event set when the last queued pipeline state object is
   // created and there are no more pipeline state objects to create. This is
   // triggered by the thread creating the last pipeline state object.
-  std::unique_ptr<xe::threading::Event> creation_completion_event_ = nullptr;
+  std::unique_ptr<xe::threading::Event> creation_completion_event_;
   // Whether setting the event on completion is queued. Protected with
   // creation_request_lock_, notify_one creation_request_cond_ when set.
   bool creation_completion_set_event_ = false;

src/xenia/gpu/d3d12/primitive_converter.h

@@ -107,7 +107,7 @@ class PrimitiveConverter {
   Memory& memory_;
   TraceWriter& trace_writer_;
 
-  std::unique_ptr<ui::d3d12::D3D12UploadBufferPool> buffer_pool_ = nullptr;
+  std::unique_ptr<ui::d3d12::D3D12UploadBufferPool> buffer_pool_;
 
   // Static index buffers for emulating unsupported primitive types when drawing
   // without an index buffer.

src/xenia/gpu/d3d12/render_target_cache.cc

@@ -36,7 +36,7 @@ namespace xe {
 namespace gpu {
 namespace d3d12 {
 
-// Generated with `xb buildhlsl`.
+// Generated with `xb gendxbc`.
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/edram_load_color_32bpp_cs.h"
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/edram_load_color_64bpp_cs.h"
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/edram_load_color_7e3_cs.h"

src/xenia/gpu/d3d12/render_target_cache.h

@@ -603,7 +603,7 @@ class RenderTargetCache {
   // For traces only.
   ID3D12Resource* edram_snapshot_download_buffer_ = nullptr;
   std::unique_ptr<ui::d3d12::D3D12UploadBufferPool>
-      edram_snapshot_restore_pool_ = nullptr;
+      edram_snapshot_restore_pool_;
 };
 
 }  // namespace d3d12

src/xenia/gpu/d3d12/shared_memory.h

@@ -212,8 +212,7 @@ class SharedMemory {
   std::vector<UploadRange> upload_ranges_;
   void GetRangesToUpload(uint32_t request_page_first,
                          uint32_t request_page_last);
-  std::unique_ptr<ui::d3d12::D3D12UploadBufferPool> upload_buffer_pool_ =
-      nullptr;
+  std::unique_ptr<ui::d3d12::D3D12UploadBufferPool> upload_buffer_pool_;
 
   // GPU-written memory downloading for traces.
   // Start page, length in pages.

src/xenia/gpu/d3d12/texture_cache.cc

@@ -53,7 +53,7 @@ namespace xe {
 namespace gpu {
 namespace d3d12 {
 
-// Generated with `xb buildhlsl`.
+// Generated with `xb gendxbc`.
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/texture_load_128bpb_2x_cs.h"
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/texture_load_128bpb_cs.h"
 #include "xenia/gpu/shaders/bytecode/d3d12_5_1/texture_load_16bpb_2x_cs.h"