[XAM] Improvement rollup. Content, enumerators...

- [Kernel] Create guest object for XEnumerator.
- [XAM] Split content data into host/guest variants.
- [XAM] Correct message return type from RESULT to HRESULT.
- [XAM] Add a new dummy content device for ODD.
- [XAM] Implement XamContentAggregateCreateEnumerator.
- [XAM] Implement XamGetPrivateEnumStructureFromHandle.
- [XAM] Implement XMsgCompleteIORequest (sketchy).
- [XAM] Implement XamGetOverlappedResult (sketchy).
- [XAM] Implement XamTaskSchedule (sketchy).

src/xenia/kernel/xam/apps/xlivebase_app.cc

@@ -22,9 +22,9 @@ XLiveBaseApp::XLiveBaseApp(KernelState* kernel_state)
 
 // http://mb.mirage.org/bugzilla/xliveless/main.c
 
-X_RESULT XLiveBaseApp::DispatchMessageSync(uint32_t message,
-                                           uint32_t buffer_ptr,
-                                           uint32_t buffer_length) {
+X_HRESULT XLiveBaseApp::DispatchMessageSync(uint32_t message,
+                                            uint32_t buffer_ptr,
+                                            uint32_t buffer_length) {
   // NOTE: buffer_length may be zero or valid.
   auto buffer = memory_->TranslateVirtual(buffer_ptr);
   switch (message) {
@@ -33,13 +33,13 @@ X_RESULT XLiveBaseApp::DispatchMessageSync(uint32_t message,
       assert_true(!buffer_length || buffer_length == 4);
       XELOGD("XLiveBaseGetLogonId({:08X})", buffer_ptr);
       xe::store_and_swap<uint32_t>(buffer + 0, 1);  // ?
-      return X_ERROR_SUCCESS;
+      return X_E_SUCCESS;
     }
     case 0x00058006: {
       assert_true(!buffer_length || buffer_length == 4);
       XELOGD("XLiveBaseGetNatType({:08X})", buffer_ptr);
       xe::store_and_swap<uint32_t>(buffer + 0, 1);  // XONLINE_NAT_OPEN
-      return X_ERROR_SUCCESS;
+      return X_E_SUCCESS;
     }
     case 0x00058020: {
       // 0x00058004 is called right before this.
@@ -48,12 +48,12 @@ X_RESULT XLiveBaseApp::DispatchMessageSync(uint32_t message,
       // buffer_length seems to be the same ptr sent to 0x00058004.
       XELOGD("XLiveBaseFriendsCreateEnumerator({:08X}, {:08X}) unimplemented",
              buffer_ptr, buffer_length);
-      return X_STATUS_UNSUCCESSFUL;
+      return X_E_FAIL;
     }
     case 0x00058023: {
       XELOGD("XliveBaseUnk58023({:08X}, {:08X}) unimplemented", buffer_ptr,
              buffer_length);
-      return X_STATUS_UNSUCCESSFUL;
+      return X_E_FAIL;
     }
     case 0x00058046: {
       // Required to be successful for Forza 4 to detect signed-in profile
@@ -61,14 +61,14 @@ X_RESULT XLiveBaseApp::DispatchMessageSync(uint32_t message,
       // input
       XELOGD("XLiveBaseUnk58046({:08X}, {:08X}) unimplemented", buffer_ptr,
              buffer_length);
-      return X_ERROR_SUCCESS;
+      return X_E_SUCCESS;
     }
   }
   XELOGE(
       "Unimplemented XLIVEBASE message app={:08X}, msg={:08X}, arg1={:08X}, "
       "arg2={:08X}",
       app_id(), message, buffer_ptr, buffer_length);
-  return X_STATUS_UNSUCCESSFUL;
+  return X_E_FAIL;
 }
 
 }  // namespace apps