fabi/Xenia-Canary
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[memory linux] Properly unlink shared memory

Browse Source 
shm_unlink(name) is the proper way to close a shared memory in linux.
Prior to this, xenia was creating and not cleaning up shared memory handle
which would accumulate in /dev/shm. shm_unlink is the proper way of doing
this.
Add filename to CloseFileMappingHandle signature.
Add simple test to open and close.
This commit is contained in:
Sandy Carter
2019-07-11 09:44:42 -04:00
committed by Triang3l
parent 2c7009ca80
commit 49e194009b
6 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/xenia/base/memory_posix.cc
View File

@@ -97,8 +97,10 @@ FileMappingHandle CreateFileMappingHandle(const std::filesystem::path& path,
return ret <= 0 ? nullptr : reinterpret_cast<FileMappingHandle>(ret);
}
void CloseFileMappingHandle(FileMappingHandle handle) {
close(static_cast<int>(reinterpret_cast<int64_t>(handle)));
void CloseFileMappingHandle(FileMappingHandle handle,
const std::filesystem::path& path) {
auto full_path = "/" / path;
shm_unlink(full_path.c_str());
}
void* MapFileView(FileMappingHandle handle, void* base_address, size_t length,