fabi/Xenia-Canary
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[threading] Linux fixes on setting an incorrect priority

Browse Source 
This call was failing since SCHED_FIFO doesn't support negative priorities, but only positive ones, see third paragraph of scheduling policies: https://man7.org/linux/man-pages/man7/sched.7.html.

Additionally Linux do provice up to 99 levels, but I've limited myself to the required UNIX standard of 32, and split the priority levels evenly from that.

I've also added a couple of rows to debug additional issues in the future like this.
This commit is contained in:
Marco Rodolfi
2025-01-16 16:19:31 +01:00
committed by Radosław Gliński
parent 4d7b30e844
commit 55bbb28a80
2 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/xenia/base/threading.h
View File

@@ -402,6 +402,7 @@ class Timer : public WaitHandle {
virtual bool Cancel() = 0; virtual bool Cancel() = 0;
}; };
#if XE_PLATFORM_WINDOWS
struct ThreadPriority { struct ThreadPriority {
static const int32_t kLowest = -2; static const int32_t kLowest = -2;
static const int32_t kBelowNormal = -1; static const int32_t kBelowNormal = -1;
@@ -409,6 +410,15 @@ struct ThreadPriority {
static const int32_t kAboveNormal = 1; static const int32_t kAboveNormal = 1;
static const int32_t kHighest = 2; static const int32_t kHighest = 2;
}; };
#else
struct ThreadPriority {
static const int32_t kLowest = 1;
static const int32_t kBelowNormal = 8;
static const int32_t kNormal = 16;
static const int32_t kAboveNormal = 24;
static const int32_t kHighest = 32;
};
#endif
// Models a Win32-like thread object. // Models a Win32-like thread object.
// https://msdn.microsoft.com/en-us/library/windows/desktop/ms682453(v=vs.85).aspx // https://msdn.microsoft.com/en-us/library/windows/desktop/ms682453(v=vs.85).aspx

16
src/xenia/base/threading_posix.cc
View File

@@ -27,6 +27,8 @@
#include <ctime> #include <ctime>
#include <memory> #include <memory>
#include "logging.h"
#if XE_PLATFORM_ANDROID #if XE_PLATFORM_ANDROID
#include <dlfcn.h> #include <dlfcn.h>
@@ -660,8 +662,18 @@ class PosixCondition<Thread> : public PosixConditionBase {
WaitStarted(); WaitStarted();
sched_param param{}; sched_param param{};
param.sched_priority = new_priority; param.sched_priority = new_priority;
if (pthread_setschedparam(thread_, SCHED_FIFO, &param) != 0) int res = pthread_setschedparam(thread_, SCHED_FIFO, &param);
assert_always(); if (res != 0) {
switch (res) {
case EPERM:
XELOGW("Permission denied while setting priority");
break;
case EINVAL:
assert_always();
default:
XELOGW("Unknown error while setting priority");
}
}
} }
void QueueUserCallback(std::function<void()> callback) { void QueueUserCallback(std::function<void()> callback) {