[UI] Redesigned "Install Content" window

- Added ID for each ImGui window
- Added filesystem::CreateFolder function

src/xenia/kernel/xam/xam_content.cc

@@ -661,8 +661,10 @@ dword_result_t XamContentLaunchImageFromFileInternal_entry(
   const std::filesystem::path host_path =
       kernel_state()->emulator()->content_root() / entry->name();
   if (!std::filesystem::exists(host_path)) {
+    uint64_t progress = 0;
+
     vfs::VirtualFileSystem::ExtractContentFile(
-        entry, kernel_state()->emulator()->content_root(), true);
+        entry, kernel_state()->emulator()->content_root(), progress, true);
   }
 
   auto xam = kernel_state()->GetKernelModule<XamModule>("xam.xex");
@@ -716,8 +718,9 @@ dword_result_t XamContentLaunchImageInternal_entry(lpvoid_t content_data_ptr,
       kernel_state()->emulator()->content_root() / entry->name();
 
   if (!std::filesystem::exists(host_path)) {
+    uint64_t progress = 0;
     kernel_state()->file_system()->ExtractContentFile(
-        entry, kernel_state()->emulator()->content_root(), true);
+        entry, kernel_state()->emulator()->content_root(), progress, true);
   }
 
   auto xam = kernel_state()->GetKernelModule<XamModule>("xam.xex");

src/xenia/kernel/xam/xam_ui.cc

@@ -58,8 +58,6 @@ namespace xam {
 
 extern std::atomic<int> xam_dialogs_shown_;
 
-constexpr ImVec2 default_image_icon_size = ImVec2(75.f, 75.f);
-
 class XamDialog : public xe::ui::ImGuiDialog {
  public:
   void set_close_callback(std::function<void()> close_callback) {
@@ -509,7 +507,8 @@ class GameAchievementsDialog final : public XamDialog {
       : XamDialog(imgui_drawer),
         drawing_position_(drawing_position),
         title_info_(*title_info),
-        profile_(profile) {
+        profile_(profile),
+        window_id_(GetWindowId()) {
     LoadAchievementsData();
   }
 
@@ -616,9 +615,9 @@ class GameAchievementsDialog final : public XamDialog {
     const auto icon = GetIcon(achievement_entry);
     if (icon) {
       ImGui::Image(reinterpret_cast<ImTextureID>(GetIcon(achievement_entry)),
-                   default_image_icon_size);
+                   ui::default_image_icon_size);
     } else {
-      ImGui::Dummy(default_image_icon_size);
+      ImGui::Dummy(ui::default_image_icon_size);
     }
     ImGui::TableNextColumn();
 
@@ -632,7 +631,7 @@ class GameAchievementsDialog final : public XamDialog {
                        GetAchievementDescription(achievement_entry).c_str());
     ImGui::PopTextWrapPos();
 
-    ImGui::SetCursorPosY(start_drawing_pos.y + default_image_icon_size.x -
+    ImGui::SetCursorPosY(start_drawing_pos.y + ui::default_image_icon_size.x -
                          ImGui::GetTextLineHeight());
 
     if (achievement_entry.IsUnlocked()) {
@@ -644,7 +643,8 @@ class GameAchievementsDialog final : public XamDialog {
     // TODO(Gliniak): There is no easy way to align text to middle, so I have to
     // do it manually.
     const float achievement_row_middle_alignment =
-        ((default_image_icon_size.x / 2.f) - ImGui::GetTextLineHeight() / 2.f) *
+        ((ui::default_image_icon_size.x / 2.f) -
+         ImGui::GetTextLineHeight() / 2.f) *
         0.85f;
 
     ImGui::SetCursorPosY(ImGui::GetCursorPosY() +
@@ -667,10 +667,13 @@ class GameAchievementsDialog final : public XamDialog {
 
     bool dialog_open = true;
 
-    if (!ImGui::Begin(fmt::format("{} Achievements List",
-                                  xe::to_utf8(title_info_.title_name))
-                          .c_str(),
-                      &dialog_open,
+    std::string title_name = xe::to_utf8(title_info_.title_name);
+    title_name.erase(std::remove(title_name.begin(), title_name.end(), '\0'),
+                     title_name.end());
+
+    const std::string window_name =
+        fmt::format("{} Achievements###{}", title_name, window_id_);
+    if (!ImGui::Begin(window_name.c_str(), &dialog_open,
                       ImGuiWindowFlags_NoCollapse |
                           ImGuiWindowFlags_AlwaysAutoResize |
                           ImGuiWindowFlags_HorizontalScrollbar)) {
@@ -688,7 +691,7 @@ class GameAchievementsDialog final : public XamDialog {
       if (ImGui::BeginTable("", 3,
                             ImGuiTableFlags_::ImGuiTableFlags_BordersInnerH)) {
         for (const auto& entry : achievements_info_) {
-          ImGui::TableNextRow(0, default_image_icon_size.y);
+          ImGui::TableNextRow(0, ui::default_image_icon_size.y);
           DrawTitleAchievementInfo(io, entry);
         }
 
@@ -707,6 +710,7 @@ class GameAchievementsDialog final : public XamDialog {
 
   bool show_locked_info_ = false;
 
+  uint64_t window_id_;
   const ImVec2 drawing_position_ = {};
 
   const TitleInfo title_info_;
@@ -724,7 +728,8 @@ class GamesInfoDialog final : public XamDialog {
         drawing_position_(drawing_position),
         profile_(profile),
         profile_manager_(kernel_state()->xam_state()->profile_manager()),
-        dialog_name_(fmt::format("{}'s Games List", profile->name())) {
+        dialog_name_(fmt::format("{}'s Games List###{}", profile->name(),
+                                 GetWindowId())) {
     LoadProfileGameInfo(imgui_drawer, profile);
   }
 
@@ -762,9 +767,9 @@ class GamesInfoDialog final : public XamDialog {
 
     if (title_icon.count(entry.id)) {
       ImGui::Image(reinterpret_cast<ImTextureID>(title_icon.at(entry.id).get()),
-                   default_image_icon_size);
+                   ui::default_image_icon_size);
     } else {
-      ImGui::Dummy(default_image_icon_size);
+      ImGui::Dummy(ui::default_image_icon_size);
     }
 
     // Second Column
@@ -779,7 +784,7 @@ class GamesInfoDialog final : public XamDialog {
                     entry.title_earned_gamerscore)
             .c_str());
 
-    ImGui::SetCursorPosY(start_position.y + default_image_icon_size.y -
+    ImGui::SetCursorPosY(start_position.y + ui::default_image_icon_size.y -
                          ImGui::GetTextLineHeight());
 
     if (entry.WasTitlePlayed()) {
@@ -881,7 +886,7 @@ class GamesInfoDialog final : public XamDialog {
 
       if (ImGui::BeginTable("", 2,
                             ImGuiTableFlags_::ImGuiTableFlags_BordersInnerH)) {
-        ImGui::TableNextRow(0, default_image_icon_size.y);
+        ImGui::TableNextRow(0, ui::default_image_icon_size.y);
         for (auto& entry : info_) {
           std::string filter(title_name_filter_);
           if (!filter.empty()) {
@@ -1564,9 +1569,10 @@ bool xeDrawProfileContent(ui::ImGuiDrawer* imgui_drawer, const uint64_t xuid,
   // In the future it can be replaced with profile icon.
   const auto icon = imgui_drawer->GetNotificationIcon(user_index);
   if (icon && user_index < XUserMaxUserCount) {
-    ImGui::Image(reinterpret_cast<ImTextureID>(icon), default_image_icon_size);
+    ImGui::Image(reinterpret_cast<ImTextureID>(icon),
+                 ui::default_image_icon_size);
   } else {
-    ImGui::Dummy(default_image_icon_size);
+    ImGui::Dummy(ui::default_image_icon_size);
   }
 
   ImGui::SameLine();