fabi/Xenia-Canary
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Build/CPU] Remove #pragma pack from Export and PPCOpcodeDisasmInfo

Browse Source 
Pack(1) causes unaligned pointer errors on ARM64 with Apple's linker.
These are static read-only tables where the ~9KB size savings from
packing is negligible. Removing the pack may also marginally improve
access speed on x86 by avoiding unaligned loads.
This commit is contained in:
Herman S.
2026-03-27 01:18:19 +09:00
parent 57c4051eca
commit 57c1af465a
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/xenia/cpu/export_resolver.h
View File

@@ -69,7 +69,6 @@ struct ExportTag {
typedef void (*xe_kernel_export_shim_fn)(void*, void*); typedef void (*xe_kernel_export_shim_fn)(void*, void*);
typedef void (*ExportTrampoline)(ppc::PPCContext* ppc_context); typedef void (*ExportTrampoline)(ppc::PPCContext* ppc_context);
#pragma pack(push, 1)
class Export { class Export {
public: public:
enum class Type { enum class Type {
@@ -113,7 +112,6 @@ class Export {
: Type::kFunction; : Type::kFunction;
} }
}; };
#pragma pack(pop)
class ExportResolver { class ExportResolver {
public: public:
class Table { class Table {

2
src/xenia/cpu/ppc/ppc_opcode_info.h
View File

@@ -133,7 +133,6 @@ enum class PPCOpcodeField : uint32_t {
kTO, kTO,
kLEV, kLEV,
}; };
#pragma pack(push, 1)
struct PPCOpcodeDisasmInfo { struct PPCOpcodeDisasmInfo {
PPCOpcodeGroup group; PPCOpcodeGroup group;
PPCOpcodeFormat format; PPCOpcodeFormat format;
@@ -144,7 +143,6 @@ struct PPCOpcodeDisasmInfo {
// std::vector<PPCOpcodeField> writes; // std::vector<PPCOpcodeField> writes;
InstrDisasmFn disasm; InstrDisasmFn disasm;
}; };
#pragma pack(pop)
PPCOpcode LookupOpcode(uint32_t code); PPCOpcode LookupOpcode(uint32_t code);
const PPCOpcodeInfo& GetOpcodeInfo(PPCOpcode opcode); const PPCOpcodeInfo& GetOpcodeInfo(PPCOpcode opcode);