C++17ification.

C++17ification!

- Filesystem interaction now uses std::filesystem::path.
- Usage of const char*, std::string have been changed to
  std::string_view where appropriate.
- Usage of printf-style functions changed to use fmt.

src/xenia/ui/vulkan/premake5.lua

@@ -7,6 +7,7 @@ project("xenia-ui-vulkan")
   kind("StaticLib")
   language("C++")
   links({
+    "fmt",
     "xenia-base",
     "xenia-ui",
     "xenia-ui-spirv",
@@ -28,6 +29,7 @@ project("xenia-ui-window-vulkan-demo")
   kind("WindowedApp")
   language("C++")
   links({
+    "fmt",
     "imgui",
     "volk",
     "xenia-base",

src/xenia/ui/vulkan/vulkan_context.cc

@@ -2,7 +2,7 @@
  ******************************************************************************
  * Xenia : Xbox 360 Emulator Research Project                                 *
  ******************************************************************************
- * Copyright 2017 Ben Vanik. All rights reserved.                             *
+ * Copyright 2020 Ben Vanik. All rights reserved.                             *
  * Released under the BSD license - see LICENSE in the root for more details. *
  ******************************************************************************
  */
@@ -27,6 +27,8 @@
 
 #if XE_PLATFORM_LINUX
 #include "xenia/ui/window_gtk.h"
+
+#include <X11/Xlib-xcb.h>
 #endif
 
 namespace xe {

src/xenia/ui/vulkan/vulkan_instance.cc

@@ -2,7 +2,7 @@
  ******************************************************************************
  * Xenia : Xbox 360 Emulator Research Project                                 *
  ******************************************************************************
- * Copyright 2017 Ben Vanik. All rights reserved.                             *
+ * Copyright 2020 Ben Vanik. All rights reserved.                             *
  * Released under the BSD license - see LICENSE in the root for more details. *
  ******************************************************************************
  */
@@ -106,7 +106,7 @@ bool VulkanInstance::EnableRenderDoc() {
   // RenderDoc injects itself into our process, so we should be able to get it.
   pRENDERDOC_GetAPI get_api = nullptr;
 #if XE_PLATFORM_WIN32
-  auto module_handle = GetModuleHandle(L"renderdoc.dll");
+  auto module_handle = GetModuleHandleW(L"renderdoc.dll");
   if (!module_handle) {
     XELOGI("RenderDoc support requested but it is not attached");
     return false;

src/xenia/ui/vulkan/vulkan_util.cc

@@ -2,13 +2,14 @@
  ******************************************************************************
  * Xenia : Xbox 360 Emulator Research Project                                 *
  ******************************************************************************
- * Copyright 2016 Ben Vanik. All rights reserved.                             *
+ * Copyright 2020 Ben Vanik. All rights reserved.                             *
  * Released under the BSD license - see LICENSE in the root for more details. *
  ******************************************************************************
  */
 
 #include "xenia/ui/vulkan/vulkan_util.h"
 
+#include "third_party/fmt/include/fmt/format.h"
 #include "xenia/base/assert.h"
 #include "xenia/base/logging.h"
 
@@ -29,8 +30,8 @@ Version Version::Parse(uint32_t value) {
   version.major = VK_VERSION_MAJOR(value);
   version.minor = VK_VERSION_MINOR(value);
   version.patch = VK_VERSION_PATCH(value);
-  version.pretty_string = xe::format_string("%u.%u.%u", version.major,
-                                            version.minor, version.patch);
+  version.pretty_string =
+      fmt::format("{}.{}.{}", version.major, version.minor, version.patch);
   return version;
 }
 

src/xenia/ui/vulkan/vulkan_window_demo.cc

@@ -2,7 +2,7 @@
  ******************************************************************************
  * Xenia : Xbox 360 Emulator Research Project                                 *
  ******************************************************************************
- * Copyright 2019 Ben Vanik. All rights reserved.                             *
+ * Copyright 2020 Ben Vanik. All rights reserved.                             *
  * Released under the BSD license - see LICENSE in the root for more details. *
  ******************************************************************************
  */
@@ -17,7 +17,7 @@
 namespace xe {
 namespace ui {
 
-int window_demo_main(const std::vector<std::wstring>& args);
+int window_demo_main(const std::vector<std::string>& args);
 
 std::unique_ptr<GraphicsProvider> CreateDemoGraphicsProvider(Window* window) {
   return xe::ui::vulkan::VulkanProvider::Create(window);
@@ -26,5 +26,4 @@ std::unique_ptr<GraphicsProvider> CreateDemoGraphicsProvider(Window* window) {
 }  // namespace ui
 }  // namespace xe
 
-DEFINE_ENTRY_POINT(L"xenia-ui-window-vulkan-demo", xe::ui::window_demo_main,
-                   "");
+DEFINE_ENTRY_POINT("xenia-ui-window-vulkan-demo", xe::ui::window_demo_main, "");