fabi/Xenia-Canary
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix potential heap corruption in code cache.

Browse Source
This commit is contained in:
Ben Vanik
2014-08-06 11:36:16 -07:00
parent d8502c2aa9
commit a085dc547e
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/alloy/backend/x64/x64_code_cache_win.cc
View File

@@ -88,7 +88,6 @@ void* X64CodeCache::PlaceCode(void* machine_code, size_t code_size,
// Add entry to fn table. // Add entry to fn table.
active_chunk_->AddTableEntry(final_address, code_size, stack_size); active_chunk_->AddTableEntry(final_address, code_size, stack_size);
lock_.unlock(); lock_.unlock();
// Copy code. // Copy code.
@@ -210,8 +209,7 @@ void X64CodeChunk::AddTableEntry(uint8_t* code, size_t code_size,
// Allocate unwind data. We know we have space because we overallocated. // Allocate unwind data. We know we have space because we overallocated.
// This should be the tailing 16b with 16b alignment. // This should be the tailing 16b with 16b alignment.
size_t unwind_info_offset = offset; size_t unwind_info_offset = offset - UNWIND_INFO_SIZE;
offset += UNWIND_INFO_SIZE;
if (!stack_size) { if (!stack_size) {
// http://msdn.microsoft.com/en-us/library/ddssxxy8.aspx // http://msdn.microsoft.com/en-us/library/ddssxxy8.aspx