[Misc] Cleanup in Kernel

src/xenia/kernel/xam/xdbf/gpd_info.h

@@ -10,14 +10,14 @@
 #ifndef XENIA_KERNEL_XAM_XDBF_GPD_INFO_H_
 #define XENIA_KERNEL_XAM_XDBF_GPD_INFO_H_
 
-#include "xenia/kernel/xam/user_data.h"
-#include "xenia/kernel/xam/xdbf/xdbf_io.h"
-
 #include <span>
 #include <string>
 #include <vector>
 
-#include "xenia/xbox.h"
+#include "xenia/base/byte_order.h"
+#include "xenia/kernel/util/xfiletime.h"
+#include "xenia/kernel/xam/user_data.h"
+#include "xenia/kernel/xam/xdbf/xdbf_io.h"
 
 namespace xe {
 namespace kernel {
@@ -111,6 +111,8 @@ class GpdInfo : public XdbfFile {
   GpdInfo(const uint32_t title_id);
   GpdInfo(const uint32_t title_id, const std::vector<uint8_t> buffer);
 
+  ~GpdInfo() = default;
+
   // Normally GPD ALWAYS contains one free entry that indicates EOF
   bool IsValid() const { return !free_entries_.empty(); }
   // r/w image, setting, string.

src/xenia/kernel/xam/xdbf/gpd_info_profile.h

@@ -29,7 +29,7 @@ class GpdInfoProfile : public GpdInfo {
   GpdInfoProfile(const std::vector<uint8_t> buffer)
       : GpdInfo(kDashboardID, buffer) {};
 
-  ~GpdInfoProfile() {};
+  ~GpdInfoProfile() = default;
 
   void AddNewTitle(const SpaInfo* title_data);
   void UpdateTitleInfo(const uint32_t title_id,

src/xenia/kernel/xam/xdbf/gpd_info_title.h

@@ -32,7 +32,7 @@ class GpdInfoTitle : public GpdInfo {
   GpdInfoTitle(const uint32_t title_id, const std::vector<uint8_t> buffer)
       : GpdInfo(title_id, buffer) {};
 
-  ~GpdInfoTitle() {};
+  ~GpdInfoTitle() = default;
 
   std::vector<uint32_t> GetAchievementsIds() const;
 

src/xenia/kernel/xam/xdbf/spa_info.h

@@ -130,6 +130,7 @@ static_assert_size(AchievementTableEntry, 0x24);
 class SpaInfo : public XdbfFile {
  public:
   SpaInfo(const std::span<uint8_t> buffer);
+  ~SpaInfo() = default;
 
   void Load();
 

src/xenia/kernel/xam/xdbf/xdbf_io.h

@@ -163,9 +163,11 @@ struct Entry {
 // https://free60project.github.io/wiki/XDBF.html
 class XdbfFile {
  public:
-  XdbfFile() {};
+  XdbfFile() = default;
   XdbfFile(const std::span<const uint8_t> buffer);
 
+  ~XdbfFile() = default;
+
   const Entry* const GetEntry(uint16_t section, uint64_t id) const;
 
  protected: