[LINT] Linted files + Added lint job to CI

src/xenia/cpu/hir/instr.h

@@ -79,10 +79,11 @@ class Instr {
   void MoveBefore(Instr* other);
   void Replace(const OpcodeInfo* new_opcode, uint16_t new_flags);
   void UnlinkAndNOP();
-  //chrispy: wanted to change this one to Remove, but i changed Remove's name to UnlinkAndNOP,
-  //so if changes happened in master that we wanted to port over, and those changes used Remove, then we would have a lot of issues that the cause of would
-  //be difficult to track 
-  //^todo: rework this comment, im frazzled
+  // chrispy: wanted to change this one to Remove, but i changed Remove's name
+  // to UnlinkAndNOP, so if changes happened in master that we wanted to port
+  // over, and those changes used Remove, then we would have a lot of issues
+  // that the cause of would be difficult to track ^todo: rework this comment,
+  // im frazzled
   void Deallocate();
   const OpcodeInfo* GetOpcodeInfo() const { return opcode; }
   // if opcode is null, we have bigger problems

src/xenia/cpu/hir/label.h

@@ -30,9 +30,7 @@ class Label {
   // this will later be used as an input to xbyak. xbyak only accepts
   // std::string as a value, not passed by reference, so precomputing the
   // stringification does not help
-  std::string GetIdString() {
-	  return std::to_string(id);
-  }
+  std::string GetIdString() { return std::to_string(id); }
 };
 
 }  // namespace hir

src/xenia/cpu/hir/value.cc

@@ -43,7 +43,7 @@ void Value::RemoveUse(Use* use) {
     use->next->prev = use->prev;
   }
 
-  //HIRBuilder::GetCurrent()->DeallocateUse(use);
+  // HIRBuilder::GetCurrent()->DeallocateUse(use);
 }
 
 uint32_t Value::AsUint32() {
@@ -1805,7 +1805,7 @@ bool Value::AllUsesByOneInsn() const {
   return true;
 }
 bool Value::AllFloatVectorLanesSameValue(const hir::Value* for_value,
-                                              uint32_t current_depth) {
+                                         uint32_t current_depth) {
   // limit recursion, otherwise this function will slow down emission
   if (current_depth == 16) {
     return false;
@@ -1819,7 +1819,8 @@ re_enter:
     xenia_assert(for_value->IsConstant());
 
     auto&& constant_value = for_value->constant.v128;
-    for (unsigned constant_lane_index = 1; constant_lane_index < 4; ++constant_lane_index) {
+    for (unsigned constant_lane_index = 1; constant_lane_index < 4;
+         ++constant_lane_index) {
       if (constant_value.u32[0] != constant_value.u32[constant_lane_index]) {
         return false;
       }
@@ -1844,9 +1845,10 @@ re_enter:
       definition_opcode_number == OPCODE_DOT_PRODUCT_3) {
     return true;
   }
-  //if splat of 32-bit value type, return true
-  //technically a splat of int16 or int8 would also produce the same "float" in all lanes
-  //but i think its best to keep this function focused on specifically float data
+  // if splat of 32-bit value type, return true
+  // technically a splat of int16 or int8 would also produce the same "float" in
+  // all lanes but i think its best to keep this function focused on
+  // specifically float data
   if (definition_opcode_number == OPCODE_SPLAT) {
     if (definition->dest->type == VEC128_TYPE) {
       auto splat_src_value_type = definition->src1.value->type;
@@ -1857,33 +1859,32 @@ re_enter:
     }
   }
 
-  switch (definition_opcode_number) { 
-      //all of these opcodes produce the same value for the same input
-  case OPCODE_RSQRT:
-  case OPCODE_RECIP:
-  case OPCODE_POW2:
-  case OPCODE_LOG2:
+  switch (definition_opcode_number) {
+      // all of these opcodes produce the same value for the same input
+    case OPCODE_RSQRT:
+    case OPCODE_RECIP:
+    case OPCODE_POW2:
+    case OPCODE_LOG2:
       for_value = definition->src1.value;
       goto re_enter;
 
-    //binary opcodes
-  case OPCODE_ADD:
-  case OPCODE_SUB:
-  case OPCODE_MUL:
+      // binary opcodes
+    case OPCODE_ADD:
+    case OPCODE_SUB:
+    case OPCODE_MUL:
       if (!AllFloatVectorLanesSameValue(definition->src1.value,
                                         current_depth + 1)) {
         return false;
       }
       for_value = definition->src2.value;
       goto re_enter;
-  default:
+    default:
       break;
   }
 
   return false;
 }
 
-
 }  // namespace hir
 }  // namespace cpu
 }  // namespace xe

src/xenia/cpu/hir/value.h

@@ -621,6 +621,7 @@ class Value {
   bool AllFloatVectorLanesSameValue() const {
     return Value::AllFloatVectorLanesSameValue(this);
   }
+
  private:
   /*
 returns true if for_value (which must be VEC128_TYPE) has the same value in