[XAM/INFO] - Implement multiple functions

- Implement XamIsSystemExperienceTitleId, XamIsSystemTitleId, XamIsXbox1TitleId
- Replaced is_title_system_type
- Changed XamIsCurrentTitleDash
- Reduced magic numbers

src/xenia/kernel/xam/profile_manager.h

@@ -17,6 +17,7 @@
 
 #include "third_party/fmt/include/fmt/format.h"
 #include "xenia/base/string.h"
+#include "xenia/kernel/title_id_utils.h"
 #include "xenia/kernel/xam/user_profile.h"
 #include "xenia/xbox.h"
 
@@ -38,7 +39,6 @@ namespace xe {
 namespace kernel {
 namespace xam {
 
-constexpr uint32_t kDashboardID = 0xFFFE07D1;
 const static std::string kDashboardStringID =
     fmt::format("{:08X}", kDashboardID);
 

src/xenia/kernel/xam/xam_info.cc

@@ -13,6 +13,7 @@
 #include "xenia/base/logging.h"
 #include "xenia/base/string_util.h"
 #include "xenia/kernel/kernel_state.h"
+#include "xenia/kernel/title_id_utils.h"
 #include "xenia/kernel/user_module.h"
 #include "xenia/kernel/util/shim_utils.h"
 #include "xenia/kernel/xam/xam_module.h"
@@ -281,7 +282,7 @@ dword_result_t XamGetCurrentTitleId_entry() {
 DECLARE_XAM_EXPORT1(XamGetCurrentTitleId, kNone, kImplemented);
 
 dword_result_t XamIsCurrentTitleDash_entry(const ppc_context_t& ctx) {
-  return ctx->kernel_state->title_id() == 0xFFFE07D1;
+  return ctx->kernel_state->title_id() == kDashboardID;
 }
 DECLARE_XAM_EXPORT1(XamIsCurrentTitleDash, kNone, kImplemented);
 
@@ -712,6 +713,21 @@ DECLARE_XAM_EXPORT1(RtlRandom, kNone, kImplemented);
 dword_result_t Refresh_entry() { return X_ERROR_SUCCESS; }
 DECLARE_XAM_EXPORT1(Refresh, kNone, kStub);
 
+dword_result_t XamIsSystemExperienceTitleId_entry(dword_t title_id) {
+  return IsSystemExperienceTitle(title_id);
+}
+DECLARE_XAM_EXPORT1(XamIsSystemExperienceTitleId, kNone, kImplemented);
+
+dword_result_t XamIsSystemTitleId_entry(dword_t title_id) {
+  return IsSystemTitle(title_id);
+}
+DECLARE_XAM_EXPORT1(XamIsSystemTitleId, kNone, kImplemented);
+
+dword_result_t XamIsXbox1TitleId_entry(dword_t title_id) {
+  return IsOriginalXboxTitle(title_id);
+}
+DECLARE_XAM_EXPORT1(XamIsXbox1TitleId, kNone, kImplemented);
+
 }  // namespace xam
 }  // namespace kernel
 }  // namespace xe

src/xenia/kernel/xam/xdbf/gpd_info_profile.h

@@ -10,6 +10,7 @@
 #ifndef XENIA_KERNEL_XAM_XDBF_GPD_INFO_PROFILE_H_
 #define XENIA_KERNEL_XAM_XDBF_GPD_INFO_PROFILE_H_
 
+#include "xenia/kernel/title_id_utils.h"
 #include "xenia/kernel/xam/xdbf/gpd_info.h"
 #include "xenia/kernel/xam/xdbf/spa_info.h"
 
@@ -24,9 +25,9 @@ namespace xam {
 
 class GpdInfoProfile : public GpdInfo {
  public:
-  GpdInfoProfile() : GpdInfo(0xFFFE07D1) {};
+  GpdInfoProfile() : GpdInfo(kDashboardID) {};
   GpdInfoProfile(const std::vector<uint8_t> buffer)
-      : GpdInfo(0xFFFE07D1, buffer) {};
+      : GpdInfo(kDashboardID, buffer) {};
 
   ~GpdInfoProfile() {};