Fixed RtlCompareString and RtlCompareStringN, they were very wrong, for CompareString the params are struct ptrs not char ptrs

Fixed a ton of clang-cl compiler warnings about unused variables, still many left. Fixed a lot of inconsistent override ones too

src/xenia/gpu/d3d12/d3d12_command_processor.cc

@@ -5152,6 +5152,7 @@ void D3D12CommandProcessor::WriteGammaRampSRV(
 #define COMMAND_PROCESSOR D3D12CommandProcessor
 
 #include "../pm4_command_processor_implement.h"
+#undef COMMAND_PROCESSOR
 }  // namespace d3d12
 }  // namespace gpu
 }  // namespace xe

src/xenia/gpu/d3d12/d3d12_command_processor.h

@@ -50,8 +50,9 @@ struct MemExportRange {
 };
 class D3D12CommandProcessor final : public CommandProcessor {
  protected:
+#define OVERRIDING_BASE_CMDPROCESSOR
 #include "../pm4_command_processor_declare.h"
-
+#undef OVERRIDING_BASE_CMDPROCESSOR
  public:
   explicit D3D12CommandProcessor(D3D12GraphicsSystem* graphics_system,
                                  kernel::KernelState* kernel_state);

src/xenia/gpu/d3d12/d3d12_texture_cache.h

@@ -87,7 +87,7 @@ class D3D12TextureCache final : public TextureCache {
 
   ~D3D12TextureCache();
 
-  void ClearCache();
+  void ClearCache() override;
 
   void BeginSubmission(uint64_t new_submission_index) override;
   void BeginFrame() override;

src/xenia/gpu/pm4_command_processor_declare.h

@@ -1,8 +1,15 @@
 
 
-void ExecuteIndirectBuffer(uint32_t ptr, uint32_t count) XE_RESTRICT;
-virtual uint32_t ExecutePrimaryBuffer(uint32_t start_index, uint32_t end_index) XE_RESTRICT;
-virtual bool ExecutePacket();
+#if defined(OVERRIDING_BASE_CMDPROCESSOR)
+#define	PM4_OVERRIDE		override
+#else
+#define PM4_OVERRIDE
+#endif
+void ExecuteIndirectBuffer(uint32_t ptr,
+                           uint32_t count) XE_RESTRICT;
+virtual uint32_t ExecutePrimaryBuffer(uint32_t start_index, uint32_t end_index)
+    XE_RESTRICT PM4_OVERRIDE;
+virtual bool ExecutePacket() PM4_OVERRIDE;
 
 public:
 void ExecutePacket(uint32_t ptr, uint32_t count);
@@ -111,4 +118,6 @@ XE_COLD
 bool ExecutePacketType3_CountOverflow(uint32_t count);
 XE_NOINLINE
 XE_COLD
-bool ExecutePacketType0_CountOverflow(uint32_t count);
+bool ExecutePacketType0_CountOverflow(uint32_t count);
+
+#undef PM4_OVERRIDE

src/xenia/gpu/vulkan/vulkan_command_processor.h

@@ -48,8 +48,9 @@ namespace vulkan {
 
 class VulkanCommandProcessor final : public CommandProcessor {
  protected:
+#define OVERRIDING_BASE_CMDPROCESSOR
 #include "../pm4_command_processor_declare.h"
-
+#undef OVERRIDING_BASE_CMDPROCESSOR
  public:
   // Single-descriptor layouts for use within a single frame.
   enum class SingleTransientDescriptorLayout {