fabi/Xenia-Canary
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Code] Remove game names from code comments (most of at least)

Browse Source
This commit is contained in:
Triang3l
2021-09-05 21:03:05 +03:00
parent 6986d6c7e8
commit e720e0a540
48 changed files with 246 additions and 245 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/xenia/kernel/xam/apps/xgi_app.cc
View File

@@ -98,7 +98,7 @@ X_HRESULT XgiApp::DispatchMessageSync(uint32_t message, uint32_t buffer_ptr,
return X_E_SUCCESS;
}
case 0x000B0014: {
// Gets Jetpac XBLA in game
// Gets 584107FB in game.
// get high score table?
XELOGD("XGI_unknown");
return X_STATUS_SUCCESS;

2
src/xenia/kernel/xam/apps/xlivebase_app.cc
View File

@@ -66,7 +66,7 @@ X_HRESULT XLiveBaseApp::DispatchMessageSync(uint32_t message,
return X_E_FAIL;
}
case 0x00058046: {
// Required to be successful for Forza 4 to detect signed-in profile
// Required to be successful for 4D530910 to detect signed-in profile
// Doesn't seem to set anything in the given buffer, probably only takes
// input
XELOGD("XLiveBaseUnk58046({:08X}, {:08X}) unimplemented", buffer_ptr,

4
src/xenia/kernel/xam/content_manager.h
View File

@@ -73,8 +73,8 @@ struct XCONTENT_DATA {
}
void set_display_name(const std::u16string_view value) {
// Some games (eg Goldeneye XBLA) require multiple null-terminators for it
// to read the string properly, blanking the array should take care of that
// Some games (e.g. 584108A9) require multiple null-terminators for it to
// read the string properly, blanking the array should take care of that
std::fill_n(display_name_raw.chars, countof(display_name_raw.chars), 0);
string_util::copy_and_swap_truncating(display_name_raw.chars, value,

5
src/xenia/kernel/xam/user_profile.cc
View File

@@ -20,9 +20,8 @@ namespace kernel {
namespace xam {
UserProfile::UserProfile() {
// NeoGeo Battle Coliseum checks the user XUID against a mask of
// 0x00C0000000000000 (3<<54), if non-zero, it prevents the user from playing
// the game.
// 58410A1F checks the user XUID against a mask of 0x00C0000000000000 (3<<54),
// if non-zero, it prevents the user from playing the game.
// "You do not have permissions to perform this operation."
xuid_ = 0xB13EBABEBABEBABE;
name_ = "User";

8
src/xenia/kernel/xam/xam_net.cc
View File

@@ -249,8 +249,10 @@ dword_result_t NetDll_WSAStartup(dword_t caller, word_t version,
data_ptr->max_sockets = wsaData.iMaxSockets;
data_ptr->max_udpdg = wsaData.iMaxUdpDg;
// Some games (PoG) want this value round-tripped - they'll compare if it
// changes and bugcheck if it does.
// Some games (5841099F) want this value round-tripped - they'll compare if
// it changes and bugcheck if it does.
// TODO(Triang3l): Verify if the title ID in the comment is correct - added
// by benvanik as an acronym initially.
uint32_t vendor_ptr = xe::load_and_swap<uint32_t>(data_out + 0x190);
xe::store_and_swap<uint32_t>(data_out + 0x190, vendor_ptr);
}
@@ -459,7 +461,7 @@ dword_result_t NetDll_XNetGetTitleXnAddr(dword_t caller,
// TODO(gibbed): A proper mac address.
// RakNet's 360 version appears to depend on abEnet to create "random" 64-bit
// numbers. A zero value will cause RakPeer::Startup to fail. This causes
// Peggle 2 to crash on startup.
// 58411436 to crash on startup.
// The 360-specific code is scrubbed from the RakNet repo, but there's still
// traces of what it's doing which match the game code.
// https://github.com/facebookarchive/RakNet/blob/master/Source/RakPeer.cpp#L382

4
src/xenia/kernel/xam/xam_notify.cc
View File

@@ -79,8 +79,8 @@ dword_result_t XNotifyGetNext(dword_t handle, dword_t match_id,
}
*id_ptr = dequeued ? id : 0;
// param_ptr may be null - Ghost Recon Advanced Warfighter 2 Demo explicitly
// passes nullptr in the code.
// param_ptr may be null - 555307F0 Demo explicitly passes nullptr in the
// code.
// https://github.com/xenia-project/xenia/pull/1577
if (param_ptr) {
*param_ptr = dequeued ? param : 0;

3
src/xenia/kernel/xam/xam_party.cc
View File

@@ -17,8 +17,7 @@ namespace kernel {
namespace xam {
dword_result_t XamPartyGetUserList(dword_t player_count, lpdword_t party_list) {
// Sonic & All-Stars Racing Transformed want specificly this code
// to skip loading party data.
// 5345085D wants specifically this code to skip loading party data.
// This code is not documented in NT_STATUS code list
return 0x807D0003;
}

2
src/xenia/kernel/xam/xam_user.cc
View File

@@ -716,7 +716,7 @@ dword_result_t XamUserCreateAchievementEnumerator(dword_t title_id,
i, // dummy image id
0,
{0, 0},
8}; // flags=8 makes dummy achievements show up in Crackdown's
8}; // flags=8 makes dummy achievements show up in 4D5307DC
// achievements list.
e->AppendItem(item);
}

2
src/xenia/kernel/xbdm/xbdm_misc.cc
View File

@@ -34,7 +34,7 @@ DECLARE_XBDM_EXPORT1(DmCloseLoadedModules, kDebug, kStub);
MAKE_DUMMY_STUB_STATUS(DmFreePool);
dword_result_t DmGetXbeInfo() {
// TODO(gibbed): Crackdown appears to expect this as success?
// TODO(gibbed): 4D5307DC appears to expect this as success?
// Unknown arguments -- let's hope things don't explode.
return 0x02DA0000;
}

2
src/xenia/kernel/xboxkrnl/xboxkrnl_audio_xma.cc
View File

@@ -119,7 +119,7 @@ static_assert_size(XMA_CONTEXT_INIT, 56);
dword_result_t XMAInitializeContext(lpvoid_t context_ptr,
pointer_t<XMA_CONTEXT_INIT> context_init) {
// Input buffers may be null (buffer 1 in Tony Hawk's American Wasteland).
// Input buffers may be null (buffer 1 in 415607D4).
// Convert to host endianness.
uint32_t input_buffer_0_guest_ptr = context_init->input_buffer_0_ptr;
uint32_t input_buffer_0_physical_address = 0;

4
src/xenia/kernel/xboxkrnl/xboxkrnl_debug.cc
View File

@@ -47,8 +47,8 @@ void HandleSetThreadName(pointer_t<X_EXCEPTION_RECORD> record) {
return;
}
// Shadowrun (and its demo) has a bug where it ends up passing freed memory
// for the name, so at the point of SetThreadName it's filled with junk.
// 4D5307D6 (and its demo) has a bug where it ends up passing freed memory for
// the name, so at the point of SetThreadName it's filled with junk.
// TODO(gibbed): cvar for thread name encoding for conversion, some games use
// SJIS and there's no way to automatically know this.

8
src/xenia/kernel/xboxkrnl/xboxkrnl_io.cc
View File

@@ -49,10 +49,10 @@ static bool IsValidPath(const std::string_view s, bool is_pattern) {
if (got_asterisk) {
// * must be followed by a . (*.)
//
// Viva Piñata: Party Animals (4D530819) has a bug in its game code where
// it attempts to FindFirstFile() with filters of "Game:\\*_X3.rkv",
// "Game:\\m*_X3.rkv", and "Game:\\w*_X3.rkv" and will infinite loop if
// the path filter is allowed.
// 4D530819 has a bug in its game code where it attempts to
// FindFirstFile() with filters of "Game:\\*_X3.rkv", "Game:\\m*_X3.rkv",
// and "Game:\\w*_X3.rkv" and will infinite loop if the path filter is
// allowed.
if (c != '.') {
return false;
}

2
src/xenia/kernel/xobject.h
View File

@@ -111,7 +111,7 @@ struct X_OBJECT_TYPE {
class XObject {
public:
// Burnout Paradise needs proper handle value for certain calculations
// 45410806 needs proper handle value for certain calculations
// It gets handle value from TLS (without base handle value is 0x88)
// and substract 0xF8000088. Without base we're receiving wrong address
// Instead of receiving address that starts with 0x82... we're receiving