fabi/Xenia-Canary
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing some clang warnings/errors.

Browse Source
This commit is contained in:
Ben Vanik
2015-07-15 23:26:58 -07:00
parent 74d2df2004
commit ecd4af10c9
27 changed files with 180 additions and 153 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/xenia/debug/debugger.cc
View File

@@ -61,8 +61,7 @@ Breakpoint::~Breakpoint() = default;
Debugger::Debugger(Emulator* emulator)
: emulator_(emulator),
listen_socket_(INVALID_SOCKET),
client_socket_(INVALID_SOCKET),
accept_thread_running_(false) {
client_socket_(INVALID_SOCKET) {
WSADATA wsa_data;
WSAStartup(MAKEWORD(2, 2), &wsa_data);
}
@@ -114,7 +113,7 @@ bool Debugger::StartSession() {
if (bind(listen_socket_, reinterpret_cast<sockaddr*>(&socket_addr),
sizeof(socket_addr)) == SOCKET_ERROR) {
int e = WSAGetLastError();
XELOGE("Unable to bind debug socket");
XELOGE("Unable to bind debug socket: %d", e);
return false;
}
if (listen(listen_socket_, 5) == SOCKET_ERROR) {
@@ -300,11 +299,12 @@ void Debugger::OnMessage(std::vector<uint8_t> buffer) {
module_builder.add_path(module_path_offset);
switch (module->module_type()) {
case XModule::ModuleType::kKernelModule: {
auto kernel_module = reinterpret_cast<XKernelModule*>(module.get());
// auto kernel_module =
// reinterpret_cast<XKernelModule*>(module.get());
break;
}
case XModule::ModuleType::kUserModule: {
auto user_module = reinterpret_cast<XUserModule*>(module.get());
// auto user_module = reinterpret_cast<XUserModule*>(module.get());
// user_module->xex?
break;
}
@@ -475,8 +475,8 @@ void Debugger::OnMessage(std::vector<uint8_t> buffer) {
break;
}
SendResponse(client_socket_, std::move(fbb), request->id(),
response_data_type, response_data_offset);
SendResponse(client_socket_, fbb, request->id(), response_data_type,
response_data_offset);
}
void Debugger::StopSession() {

8
src/xenia/debug/debugger.h
View File

@@ -108,13 +108,13 @@ class Debugger {
private:
void OnMessage(std::vector<uint8_t> buffer);
Emulator* emulator_;
Emulator* emulator_ = nullptr;
uintptr_t listen_socket_;
bool accept_thread_running_;
uintptr_t listen_socket_ = ~0;
bool accept_thread_running_ = false;
std::thread accept_thread_;
xe::threading::Fence accept_fence_;
uintptr_t client_socket_;
uintptr_t client_socket_ = ~0;
std::thread receive_thread_;
std::wstring functions_path_;