The guest-PC branch probe exists only on the snapshot branch, not on sylpheed-re #1

New Issue

fabi · 2026-09-17T19:02:22Z

fabi commented

2026-09-17 19:02:22 +00:00

run-canary-safe.sh launches Canary with --audit_61_branch_probe_pcs=<pcs>, and the desktop's /sylph-canary skill — the project's main dynamic-RE instrument — is built entirely on that cvar.

The cvar is defined only on auto/canary-instrumentation-snapshot-2026-07-28 (30d05ee97, the commit that preserved instrumentation which had never been committed). It is absent from sylpheed-re, the default branch, and from auto/re-frame-probe, which the native build tracks:

$ git grep -l audit_61 fork/sylpheed-re -- src     # nothing
$ git grep -l audit_61 auto/canary-instrumentation-snapshot-2026-07-28 -- src
src/xenia/cpu/cpu_flags.cc
src/xenia/cpu/cpu_flags.h
src/xenia/cpu/ppc/ppc_hir_builder.cc

Consequences. The only binary that can take PC probes is the Wine cross-build from 2026-05-21; the native build (2026-08-14) cannot. Rebuilding either from the default branch silently drops the probe, and the launcher would pass a flag the binary does not define.

Fix. Bring 30d05ee97, and a15430902 (the Phase-A tracer it sits on), onto sylpheed-re behind their existing cvar gates, which default off, then rebuild both binaries from it.

`run-canary-safe.sh` launches Canary with `--audit_61_branch_probe_pcs=<pcs>`, and the desktop's `/sylph-canary` skill — the project's main dynamic-RE instrument — is built entirely on that cvar. The cvar is defined **only** on `auto/canary-instrumentation-snapshot-2026-07-28` (`30d05ee97`, the commit that preserved instrumentation which had never been committed). It is absent from `sylpheed-re`, the default branch, and from `auto/re-frame-probe`, which the native build tracks: ``` $ git grep -l audit_61 fork/sylpheed-re -- src # nothing $ git grep -l audit_61 auto/canary-instrumentation-snapshot-2026-07-28 -- src src/xenia/cpu/cpu_flags.cc src/xenia/cpu/cpu_flags.h src/xenia/cpu/ppc/ppc_hir_builder.cc ``` **Consequences.** The only binary that can take PC probes is the Wine cross-build from 2026-05-21; the native build (2026-08-14) cannot. Rebuilding either from the default branch silently drops the probe, and the launcher would pass a flag the binary does not define. **Fix.** Bring `30d05ee97`, and `a15430902` (the Phase-A tracer it sits on), onto `sylpheed-re` behind their existing cvar gates, which default off, then rebuild both binaries from it.

fabi referenced this issue from a commit

2026-09-20 18:57:37 +00:00

[Audit] bring the audit_61 branch probe onto sylpheed-re

fabi referenced a pull request that will close this issue

2026-09-20 18:58:07 +00:00

[Audit] bring the audit_61 branch probe onto sylpheed-re #2

fabi closed this issue

2026-09-21 16:03:11 +00:00

Sign in to join this conversation.