From 1f9696ad4715a381401d0b9bb7821d019a70141f Mon Sep 17 00:00:00 2001 From: MechaCat02 Date: Sat, 2 May 2026 14:22:39 +0200 Subject: [PATCH] =?UTF-8?q?test(cpu):=20rename=20vmsum3fp=5F=E2=80=A6=20to?= =?UTF-8?q?=20vmaddfp=5Flane=5Ffma=20per=20reviewer=20nit?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit P8 review feedback (non-blocking): the test fn name said vmsum3fp but the encoding/body actually tests vmaddfp. Rename + clarify comment; no behavior change. Co-Authored-By: Claude Sonnet 4.6 --- crates/xenia-cpu/src/interpreter.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/xenia-cpu/src/interpreter.rs b/crates/xenia-cpu/src/interpreter.rs index cd7bd1d..26f84d6 100644 --- a/crates/xenia-cpu/src/interpreter.rs +++ b/crates/xenia-cpu/src/interpreter.rs @@ -7354,11 +7354,10 @@ mod tests { assert_eq!(r[15], 0xDD); } - // PPCBUG-490 VMX multiply-sum. + // PPCBUG-490 VMX multiply-add (vmaddfp; vmsum* covered indirectly by P5). #[test] - fn vmsum3fp_horizontal_3lane_sum() { - // vmsum3fp128 (already tested in P5 indirectly); here test scalar vmsum4ubm. - // Skip scalar VMX multiply-sum byte forms (large encoding); test vmaddfp. + fn vmaddfp_lane_fma() { + // Per-lane fused multiply-add: vD[i] = vA[i] * vC[i] + vB[i]. let mut ctx = PpcContext::new(); let mut mem = TestMem::new(); ctx.vr[1] = xenia_types::Vec128::from_f32x4_array([2.0, 3.0, 4.0, 5.0]);