bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
68 lines
2.7 KiB
TypeScript
68 lines
2.7 KiB
TypeScript
/**
|
|
* Shared seed helpers so specs don't each hand-roll the upload/comment create
|
|
* flow. Centralising the API contract (routes, field names, expected statuses)
|
|
* means an API change is a one-file edit, not a 7-file hunt.
|
|
*/
|
|
import { readFileSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
import { uploadRaw } from './upload-client';
|
|
import { db } from '../fixtures/db';
|
|
import { BASE } from './env';
|
|
|
|
// A real, decodable JPEG. Magic-bytes-only fakes now get auto-cleaned by the
|
|
// backend when compression fails (a failed transcode refunds quota + deletes the
|
|
// row), which would delete the seeded upload out from under the test. Read lazily
|
|
// at call time (cwd is the e2e dir at runtime, like the gallery-path spec) so test
|
|
// collection can't trip on a module-load read.
|
|
let sampleJpg: Buffer | null = null;
|
|
function sampleImage(): Buffer {
|
|
if (!sampleJpg) {
|
|
sampleJpg = readFileSync(join(process.cwd(), 'fixtures', 'media', 'sample.jpg'));
|
|
}
|
|
return sampleJpg;
|
|
}
|
|
|
|
export type SeedUploadOptions = {
|
|
caption?: string;
|
|
/** Mark compression done so the card is fully rendered in the feed. Default true. */
|
|
visible?: boolean;
|
|
};
|
|
|
|
/** Seed a real, accepted upload owned by `jwt` and return its id. */
|
|
export async function seedUpload(jwt: string, opts: SeedUploadOptions = {}): Promise<string> {
|
|
const res = await uploadRaw(jwt, sampleImage(), {
|
|
filename: 'a.jpg',
|
|
contentType: 'image/jpeg',
|
|
caption: opts.caption,
|
|
});
|
|
if (res.status !== 201) throw new Error(`seedUpload failed: ${res.status} ${await res.text()}`);
|
|
const { id } = await res.json();
|
|
if (opts.visible !== false) await db.setUploadCompressionStatus(id, 'done');
|
|
return id;
|
|
}
|
|
|
|
/** Seed a comment on `uploadId` authored by `jwt`; return its id. */
|
|
export async function seedComment(jwt: string, uploadId: string, body: string): Promise<string> {
|
|
const res = await fetch(`${BASE}/api/v1/upload/${uploadId}/comments`, {
|
|
method: 'POST',
|
|
headers: { Authorization: `Bearer ${jwt}`, 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ body }),
|
|
});
|
|
if (res.status !== 201) throw new Error(`seedComment failed: ${res.status} ${await res.text()}`);
|
|
return (await res.json()).id;
|
|
}
|
|
|
|
/** Read the comments for an upload as `jwt`. */
|
|
export async function listComments(jwt: string, uploadId: string): Promise<any[]> {
|
|
const res = await fetch(`${BASE}/api/v1/upload/${uploadId}/comments`, {
|
|
headers: { Authorization: `Bearer ${jwt}` },
|
|
});
|
|
return res.json();
|
|
}
|
|
|
|
/** Resolve a single upload row from a feed response whose envelope shape isn't pinned. */
|
|
export function findFeedRow(feed: any, id: string): any {
|
|
const list: any[] = feed.uploads ?? feed.items ?? feed;
|
|
return Array.isArray(list) ? list.find((u: any) => u.id === id) : undefined;
|
|
}
|