bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
44 lines
1.4 KiB
TypeScript
44 lines
1.4 KiB
TypeScript
/**
|
|
* Shared SSE-flow helpers. The stream auth flow (mint a single-use ticket, open
|
|
* with `?ticket=`) is security-sensitive and recently changed from `?token=`, so
|
|
* it lives in one place instead of being re-inlined per spec.
|
|
*/
|
|
import type { Page } from '@playwright/test';
|
|
import { BASE } from './env';
|
|
|
|
/** Exchange a JWT for a single-use SSE ticket via POST /api/v1/stream/ticket. */
|
|
export async function mintSseTicket(jwt: string): Promise<string> {
|
|
const res = await fetch(`${BASE}/api/v1/stream/ticket`, {
|
|
method: 'POST',
|
|
headers: { Authorization: `Bearer ${jwt}` },
|
|
});
|
|
if (res.status !== 200)
|
|
throw new Error(`mintSseTicket failed: ${res.status} ${await res.text()}`);
|
|
return (await res.json()).ticket;
|
|
}
|
|
|
|
/** Open the SSE stream with a ticket, return the HTTP status, and tear the stream down. */
|
|
export async function openStream(ticket: string): Promise<number> {
|
|
const c = new AbortController();
|
|
try {
|
|
const res = await fetch(`${BASE}/api/v1/stream?ticket=${encodeURIComponent(ticket)}`, {
|
|
signal: c.signal,
|
|
});
|
|
return res.status;
|
|
} finally {
|
|
c.abort();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Count EventSource opens (GET /api/v1/stream?ticket=…) on a page — NOT the ticket
|
|
* POST. Returns a getter for the running count.
|
|
*/
|
|
export function trackStreamOpens(page: Page): () => number {
|
|
let n = 0;
|
|
page.on('request', (req) => {
|
|
if (req.method() === 'GET' && req.url().includes('/api/v1/stream?')) n++;
|
|
});
|
|
return () => n;
|
|
}
|