The idempotency key was only readable as a multipart FIELD, and a field cannot be read until the body is being parsed — which happens after the lock/release pre-flight. So the replay was unreachable in exactly the case it exists for: the photo commits → the response is lost on the way back (the flaky-wifi failure the key was added for) → the host releases the gallery at the end of the night → the phone's retry answers `gallery_released`. The guest is told a photo that is sitting in the gallery was never sent. And the remedy the client offers is destructive: `open_event` clears `export_released_at` AND bumps `export_epoch`, retiring the whole keepsake generation and forcing a multi-GB rebuild on a 2-vCPU box at midnight — to re-send a photo that was never missing. Several guests on one flaky evening make this likely to happen at least once. The key is now also sent as `X-Client-Upload-Id`, which arrives with the request line, so the answer is knowable before anything is decided about locks. The multipart field stays for the concurrent case and as a fallback. Placed ahead of the hourly rate limiter too, which was the same mistake one layer up: a 40-photo burst with two retries apiece exhausted the guest's hour on uploads that had all committed the first time. The body is still drained rather than abandoned — replying before reading it makes the proxy see a broken pipe and turn a clean 200 into a 502. The spec carries its own control: a DIFFERENT photo is asserted to still be refused with `gallery_released` after the release, so the replay cannot be green merely because the gate was open.
128 lines
5.2 KiB
TypeScript
128 lines
5.2 KiB
TypeScript
import { BASE } from './env';
|
|
/**
|
|
* Node-side multipart upload helper. Lets adversarial specs post arbitrary
|
|
* bytes with arbitrary `Content-Type` claims to /api/v1/upload without
|
|
* driving the UI. Crucial for MIME-spoofing, oversize, polyglot, and
|
|
* filename-injection tests.
|
|
*
|
|
* Field shape matches [backend/src/handlers/upload.rs]:
|
|
* - file (binary; carries filename + content_type in the part headers)
|
|
* - client_upload_id (uuid, optional; also sent as the X-Client-Upload-Id header)
|
|
* - caption (text, optional)
|
|
* - hashtags (CSV text, optional)
|
|
*/
|
|
// Node 22+ ships FormData and Blob as globals — no import needed.
|
|
|
|
export type UploadOptions = {
|
|
filename?: string;
|
|
contentType?: string;
|
|
caption?: string;
|
|
hashtags?: string;
|
|
/**
|
|
* Idempotency key. Sent BOTH as the `X-Client-Upload-Id` header and as the multipart field,
|
|
* exactly as the real client does — the header is what lets the server replay a stored upload
|
|
* before it evaluates the lock/release gate, and the field covers the concurrent case.
|
|
*/
|
|
clientUploadId?: string;
|
|
};
|
|
|
|
export async function uploadRaw(
|
|
token: string,
|
|
body: Uint8Array | Buffer,
|
|
opts: UploadOptions = {}
|
|
) {
|
|
const form = new FormData();
|
|
const blob = new Blob([body as any], { type: opts.contentType ?? 'application/octet-stream' });
|
|
form.append('file', blob as any, opts.filename ?? 'upload.bin');
|
|
if (opts.caption !== undefined) form.append('caption', opts.caption);
|
|
if (opts.hashtags !== undefined) form.append('hashtags', opts.hashtags);
|
|
if (opts.clientUploadId !== undefined) form.append('client_upload_id', opts.clientUploadId);
|
|
const headers: Record<string, string> = { Authorization: `Bearer ${token}` };
|
|
if (opts.clientUploadId !== undefined) headers['X-Client-Upload-Id'] = opts.clientUploadId;
|
|
return fetch(`${BASE}/api/v1/upload`, {
|
|
method: 'POST',
|
|
headers,
|
|
body: form as any,
|
|
});
|
|
}
|
|
|
|
/** Convenience: read a fixture from disk and upload it. */
|
|
export async function uploadFile(token: string, path: string, opts: UploadOptions = {}) {
|
|
const { readFile } = await import('node:fs/promises');
|
|
const body = await readFile(path);
|
|
return uploadRaw(token, body, opts);
|
|
}
|
|
|
|
/** Tiny valid JPEG header — magic bytes only, useful for "claim image but is N MB of zeros" tests. */
|
|
export const JPEG_MAGIC = new Uint8Array([
|
|
0xff, 0xd8, 0xff, 0xe0, 0x00, 0x10, 0x4a, 0x46, 0x49, 0x46,
|
|
]);
|
|
/** Tiny valid PNG magic bytes. */
|
|
export const PNG_MAGIC = new Uint8Array([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a]);
|
|
/** ELF header — the magic bytes of a Linux executable. `infer` reports `application/x-executable`. */
|
|
export const ELF_MAGIC = new Uint8Array([0x7f, 0x45, 0x4c, 0x46]);
|
|
|
|
/**
|
|
* Upload whose request body PAUSES mid-stream until you release it.
|
|
*
|
|
* This exists to make the release-vs-upload race deterministic instead of hoped-for. The bug it
|
|
* guards is a TOCTOU: `upload` checks `uploads_locked_at` BEFORE reading the body (minutes, for a
|
|
* big video) and commits the row afterwards — so a release landing in between used to let the photo
|
|
* commit AFTER the export snapshot, leaving it in the live feed but permanently absent from the
|
|
* keepsake.
|
|
*
|
|
* Racing N normal uploads against a release can't prove anything: if they all happen to commit
|
|
* first (or all get rejected), the assertion passes on broken code too. Here the server is *stuck*
|
|
* mid-body with its pre-flight check already passed, so the release provably lands inside the
|
|
* window. Await `checkPassed`, fire the release, then `finish()`.
|
|
*/
|
|
export function uploadPausedMidStream(
|
|
token: string,
|
|
head: Buffer,
|
|
tail: Buffer,
|
|
opts: UploadOptions = {}
|
|
): { checkPassed: Promise<void>; finish: () => void; response: Promise<Response> } {
|
|
const boundary = '----eventsnapPausedBoundary' + Math.random().toString(16).slice(2);
|
|
const filename = opts.filename ?? 'paused.jpg';
|
|
const contentType = opts.contentType ?? 'image/jpeg';
|
|
|
|
const preamble = Buffer.from(
|
|
`--${boundary}\r\n` +
|
|
`Content-Disposition: form-data; name="file"; filename="${filename}"\r\n` +
|
|
`Content-Type: ${contentType}\r\n\r\n`
|
|
);
|
|
const epilogue = Buffer.from(`\r\n--${boundary}--\r\n`);
|
|
|
|
let releaseBody: () => void;
|
|
const gate = new Promise<void>((r) => (releaseBody = r));
|
|
let markCheckPassed: () => void;
|
|
const checkPassed = new Promise<void>((r) => (markCheckPassed = r));
|
|
|
|
const body = new ReadableStream<Uint8Array>({
|
|
async pull(controller) {
|
|
controller.enqueue(new Uint8Array(preamble));
|
|
controller.enqueue(new Uint8Array(head));
|
|
// The server has now read the part headers and the first bytes — which means it is PAST its
|
|
// pre-flight lock check and is sitting in the body loop. This is the window.
|
|
markCheckPassed();
|
|
await gate;
|
|
controller.enqueue(new Uint8Array(tail));
|
|
controller.enqueue(new Uint8Array(epilogue));
|
|
controller.close();
|
|
},
|
|
});
|
|
|
|
const response = fetch(`${BASE}/api/v1/upload`, {
|
|
method: 'POST',
|
|
headers: {
|
|
Authorization: `Bearer ${token}`,
|
|
'Content-Type': `multipart/form-data; boundary=${boundary}`,
|
|
},
|
|
body,
|
|
// Node's fetch requires this for a streaming request body.
|
|
duplex: 'half',
|
|
} as RequestInit & { duplex: 'half' });
|
|
|
|
return { checkPassed, finish: () => releaseBody(), response };
|
|
}
|