bbdfae09a0
The Playwright suite had no linter and no formatter — only tsc. Add flat-config ESLint
(typescript-eslint, type-aware) and Prettier (2-space, matching the suite's style).
Rules keep the ones that catch real TEST bugs and drop the noise:
- no-floating-promises KEPT — an un-awaited request/assertion can let a test end before it runs,
passing vacuously. It caught one: the SSE reader loop in sse-listener is now explicitly `void`.
- no-unused-vars KEPT — caught three dead bindings (an unused adminToken fixture arg, an unused
`api` arg, an unused JPEG_MAGIC import), all removed.
- no-explicit-any OFF — all test code; `any` is the honest type for an untyped res.json() body or
a page.evaluate() return.
- no-empty-pattern OFF — Playwright's dependency-free fixtures are `async ({}, use) => {}`.
Refactor: `const BASE = process.env.E2E_FRONTEND_URL ?? '...'` was redeclared verbatim in 23
files — extracted to helpers/env.ts and imported, so a port/scheme change is one edit not a sweep.
Then `prettier --write`. Verified: eslint clean, tsc clean, prettier clean, desktop suite 210
passed / 1 skipped. (One mobile spec flaked once under retries:0 — a pre-existing cross-test
reflow-timing vector from the flakiness audit, not this change: the each-key edit is stable across
16 isolated runs and a clean full mobile re-run.)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
53 lines
2.0 KiB
TypeScript
53 lines
2.0 KiB
TypeScript
/**
|
|
* USER_JOURNEYS.md §11 — admin login. Tests the /admin/login route and
|
|
* the redirect-while-already-logged-in shortcut.
|
|
*/
|
|
import { test, expect } from '../../fixtures/test';
|
|
import { AdminLoginPage } from '../../page-objects';
|
|
import { ADMIN_PASSWORD } from '../../fixtures/api-client';
|
|
|
|
test.describe('Auth — admin login', () => {
|
|
test('correct password → /admin dashboard', async ({ page }) => {
|
|
const login = new AdminLoginPage(page);
|
|
await login.goto();
|
|
await login.login(ADMIN_PASSWORD);
|
|
await page.waitForURL('**/admin', { timeout: 10_000 });
|
|
|
|
// The admin JWT lands in sessionStorage (USER_JOURNEYS §11.1) — NOT localStorage — so the
|
|
// elevated credential doesn't survive a tab/browser close on a shared "event laptop".
|
|
const stores = await page.evaluate(() => {
|
|
const decodeRole = (t: string | null) => {
|
|
if (!t) return null;
|
|
try {
|
|
return JSON.parse(atob(t.split('.')[1])).role;
|
|
} catch {
|
|
return null;
|
|
}
|
|
};
|
|
return {
|
|
sessionRole: decodeRole(sessionStorage.getItem('eventsnap_jwt')),
|
|
localToken: localStorage.getItem('eventsnap_jwt'),
|
|
};
|
|
});
|
|
expect(stores.sessionRole).toBe('admin');
|
|
expect(stores.localToken, 'admin token must not persist in localStorage').toBeNull();
|
|
});
|
|
|
|
test('wrong password → error, no token written', async ({ page }) => {
|
|
const login = new AdminLoginPage(page);
|
|
await login.goto();
|
|
await login.login('definitely-not-the-password');
|
|
await expect(login.errorMessage).toContainText(/falsch|forbidden|password/i);
|
|
const token = await page.evaluate(() => localStorage.getItem('eventsnap_jwt'));
|
|
expect(token).toBeNull();
|
|
});
|
|
|
|
test('already logged in as admin → auto-redirect to /admin', async ({ page, api }) => {
|
|
const adminJwt = await api.adminLogin();
|
|
await page.goto('/');
|
|
await page.evaluate((jwt) => localStorage.setItem('eventsnap_jwt', jwt), adminJwt);
|
|
await page.goto('/admin/login');
|
|
await page.waitForURL('**/admin', { timeout: 5_000 });
|
|
});
|
|
});
|