Three distinct load-induced flakes in the mobile suite, all root-caused from real traces: 1. gestures-longpress "quick tap": longPress() drove page.mouse.down + Node-side waitForTimeout(200) + page.mouse.up — three CDP round-trips. Under load the browser saw the pointerup >500ms after pointerdown, firing the app's real long-press so the ContextSheet opened on a quick tap. New quickTap() helper dispatches pointerdown/up entirely in-browser on one clock, so the earlier-due pointerup always cancels the 500ms timer first — immune to CDP latency. 2/3. upload-cancel-confirm and sheet-escape interacted with server-rendered controls before Svelte hydrated them (caption fill lost -> cancel() navigates to /feed; custom role=radio / leave-button click no-ops). Wait for a post-hydration readiness signal (composer auto-focus / real profile name) before the first interaction — the same barrier the passing feed-based specs already have. (These are now belt-and-suspenders given ssr=false, but keep the specs robust regardless of render mode.) Verified: mobile 22/22, and 0/50 full-mobile runs under load (was ~3/95 pre-fix). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
145 lines
5.9 KiB
TypeScript
145 lines
5.9 KiB
TypeScript
/**
|
|
* Touch-gesture primitives for Phase 3 mobile specs.
|
|
*
|
|
* The app uses two custom Svelte actions:
|
|
*
|
|
* 1. `longpress` — listens for `pointerdown`, starts a 500 ms timer,
|
|
* cancels on pointerup / pointermove > 10 px / pointercancel.
|
|
* [frontend/src/lib/actions/longpress.ts]
|
|
*
|
|
* 2. `doubletap` — listens for `pointerup` and times consecutive
|
|
* releases within 300 ms on roughly the same coordinate.
|
|
* [frontend/src/lib/actions/doubletap.ts]
|
|
*
|
|
* Both listen to pointer events, which fire from mouse, touch, and pen
|
|
* input. We drive them with `page.mouse` because it works identically
|
|
* across all Playwright engines and respects the project's mobile
|
|
* viewport — the action doesn't care whether the underlying device was
|
|
* touch or mouse.
|
|
*/
|
|
import type { Locator, Page } from '@playwright/test';
|
|
|
|
async function centerOf(locator: Locator): Promise<{ x: number; y: number }> {
|
|
const box = await locator.boundingBox();
|
|
if (!box) throw new Error(`Cannot get bounding box for locator (not visible?)`);
|
|
return { x: box.x + box.width / 2, y: box.y + box.height / 2 };
|
|
}
|
|
|
|
/** Hold the pointer down on `locator` for `durationMs`. Default 600 ms beats the 500 ms long-press threshold. */
|
|
export async function longPress(page: Page, locator: Locator, durationMs = 600) {
|
|
const { x, y } = await centerOf(locator);
|
|
await page.mouse.move(x, y);
|
|
await page.mouse.down();
|
|
await page.waitForTimeout(durationMs);
|
|
await page.mouse.up();
|
|
}
|
|
|
|
/**
|
|
* A sub-threshold press dispatched ENTIRELY in-browser: `pointerdown`, an in-browser
|
|
* `setTimeout(holdMs)`, then `pointerup` — all on the element carrying `use:longpress`.
|
|
*
|
|
* Why not `longPress` (page.mouse + waitForTimeout) for the "quick tap must NOT long-press"
|
|
* case: those are three independent CDP round-trips with a Node-side wait between the down
|
|
* and the up. Under cross-test load the browser can process the `pointerup` far later than
|
|
* `holdMs` of *browser* time, so the app's real 500 ms long-press timer fires and the
|
|
* ContextSheet opens on what the test intended as a quick tap. (Observed: a 200 ms-intended
|
|
* tap opening the sheet ~1 % of full-suite runs.) Dispatching both events from one
|
|
* `evaluate` puts the down→up gap and the app's 500 ms timer on the SAME clock: even if the
|
|
* event loop stalls, the earlier-scheduled `pointerup` (holdMs) still fires before the
|
|
* later 500 ms timer, so the relationship holds. Mirrors `doubleTap`.
|
|
*
|
|
* No trusted `click` follows a synthetic `pointerup`, so use this ONLY where the assertion is
|
|
* that the long-press did NOT fire — not where a real click must land (see `longPress`).
|
|
*/
|
|
export async function quickTap(locator: Locator, holdMs = 200) {
|
|
await locator.evaluate((el: HTMLElement, ms: number) => {
|
|
const rect = el.getBoundingClientRect();
|
|
const x = rect.left + rect.width / 2;
|
|
const y = rect.top + rect.height / 2;
|
|
const mk = (type: string) =>
|
|
new PointerEvent(type, {
|
|
bubbles: true,
|
|
cancelable: true,
|
|
clientX: x,
|
|
clientY: y,
|
|
pointerType: 'touch',
|
|
isPrimary: true,
|
|
});
|
|
el.dispatchEvent(mk('pointerdown'));
|
|
return new Promise<void>((resolve) =>
|
|
setTimeout(() => {
|
|
el.dispatchEvent(mk('pointerup'));
|
|
resolve();
|
|
}, ms)
|
|
);
|
|
}, holdMs);
|
|
}
|
|
|
|
/**
|
|
* Two rapid pointer-event pairs within the doubletap action's 300 ms window.
|
|
*
|
|
* Dispatches synthetic `pointerdown`/`pointerup` directly on the element via
|
|
* `page.evaluate` (not via `page.mouse`). Why: with real mouse events, the
|
|
* first tap fires the element's `onclick` synchronously — which on a
|
|
* FeedListCard image button means the lightbox opens *before* the second tap
|
|
* lands. That makes mouse-driven double-tap impossible to test in headless
|
|
* Chromium. Dispatching pointer events bypasses the synthetic click pipeline
|
|
* entirely, so we can exercise the `doubletap` action's contract directly.
|
|
*/
|
|
export async function doubleTap(page: Page, locator: Locator) {
|
|
await locator.evaluate((el: HTMLElement) => {
|
|
const rect = el.getBoundingClientRect();
|
|
const x = rect.left + rect.width / 2;
|
|
const y = rect.top + rect.height / 2;
|
|
const mk = (type: string) =>
|
|
new PointerEvent(type, {
|
|
bubbles: true,
|
|
cancelable: true,
|
|
clientX: x,
|
|
clientY: y,
|
|
pointerType: 'touch',
|
|
isPrimary: true,
|
|
});
|
|
el.dispatchEvent(mk('pointerdown'));
|
|
el.dispatchEvent(mk('pointerup'));
|
|
// Second tap < 300 ms later.
|
|
return new Promise<void>((resolve) =>
|
|
setTimeout(() => {
|
|
el.dispatchEvent(mk('pointerdown'));
|
|
el.dispatchEvent(mk('pointerup'));
|
|
resolve();
|
|
}, 50)
|
|
);
|
|
});
|
|
}
|
|
|
|
/** Touch swipe from start to end coordinates via the touchscreen API (mobile viewports). */
|
|
export async function swipe(
|
|
page: Page,
|
|
from: { x: number; y: number },
|
|
to: { x: number; y: number },
|
|
steps = 10
|
|
) {
|
|
// page.touchscreen.tap exists but doesn't expose move; fall back to dispatching
|
|
// raw touch events via page.evaluate when needed. For now, mouse-based pointer
|
|
// events are equivalent because the app's planned swipe handlers (when they
|
|
// land) will use pointer events too.
|
|
await page.mouse.move(from.x, from.y);
|
|
await page.mouse.down();
|
|
for (let i = 1; i <= steps; i++) {
|
|
const t = i / steps;
|
|
await page.mouse.move(from.x + (to.x - from.x) * t, from.y + (to.y - from.y) * t);
|
|
}
|
|
await page.mouse.up();
|
|
}
|
|
|
|
/** Read computed style on a locator. Useful for asserting `padding-bottom` includes env(safe-area-inset-bottom). */
|
|
export async function computedStyle(locator: Locator, prop: string): Promise<string> {
|
|
return locator.evaluate((el, p) => getComputedStyle(el).getPropertyValue(p), prop);
|
|
}
|
|
|
|
/** Read the raw inline `style` attribute (env() vars expand only inside computed style, not here). */
|
|
export async function inlineStyle(locator: Locator): Promise<string> {
|
|
return locator.evaluate((el) => (el as HTMLElement).getAttribute('style') ?? '');
|
|
}
|