fabi/Mangalord
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ui): fold the 36px header/search buttons into IconButton #16

Closed
fabi wants to merge 1 commits from refactor/icon-button-outliers into refactor/shared-icon-button
pull from: refactor/icon-button-outliers
merge into: fabi:refactor/shared-icon-button
Conversation 0 Commits 1 Files Changed 4 +62 -54
fabi commented 2026-06-25 17:48:09 +00:00
Owner
Copy Link

Stacked on #15 (base is refactor/shared-icon-button, not main) — review/merge #15 first.

Completes the IconButton extraction by adding size and radius props and converting the two outliers left out of the first pass: the desktop header logout button (+layout) and the home search submit button (+page), both 36px with the medium radius.

IconButton now drives every icon button in the app except profile/history's, which #13 removes separately. Defaults stay 32px / small radius, so the four already-converted sites are untouched. Rendered size, radius, and variant match the old markup — no behaviour change, no version bump.

Sets up applying the --tap-min touch floor in one place once #12 lands.

Testing

Two new IconButton cases (size/radius); 358/358 vitest pass; svelte-check clean. e2e: auth-flow logout green, home renders green. (The pre-existing, unrelated search updates e2e failure reproduces on baseline.)

🤖 Generated with Claude Code

**Stacked on #15** (base is `refactor/shared-icon-button`, not `main`) — review/merge #15 first. Completes the IconButton extraction by adding `size` and `radius` props and converting the two outliers left out of the first pass: the desktop header **logout** button (`+layout`) and the home **search** submit button (`+page`), both 36px with the medium radius. IconButton now drives every icon button in the app except `profile/history`'s, which #13 removes separately. Defaults stay 32px / small radius, so the four already-converted sites are untouched. Rendered size, radius, and variant match the old markup — **no behaviour change, no version bump**. Sets up applying the `--tap-min` touch floor in one place once #12 lands. ## Testing Two new IconButton cases (size/radius); 358/358 vitest pass; svelte-check clean. e2e: auth-flow logout green, home renders green. (The pre-existing, unrelated `search updates` e2e failure reproduces on baseline.) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fabi added 1 commit 2026-06-25 17:48:09 +00:00
refactor(ui): fold the 36px header/search buttons into IconButton 79a1432db8 
Completes the IconButton extraction by adding `size` and `radius` props and
converting the two remaining outliers that were left out of the first pass:
the desktop header logout button (+layout) and the home search submit button
(+page), both 36px with the medium radius.

IconButton now drives every icon button in the app (except profile/history's,
which the shared-HistoryList change removes separately). Defaults stay 32px /
small radius, so the four already-converted sites are untouched. Rendered
size, radius, and variant match the old markup — no behaviour change, no
version bump.

This also sets up applying the --tap-min touch floor in one place once the
touch-target change lands.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fabi closed this pull request 2026-06-26 18:23:58 +00:00
fabi deleted branch refactor/icon-button-outliers 2026-06-26 18:23:58 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
fabi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fabi/Mangalord#16
Delete Branch "refactor/icon-button-outliers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?