test(crawler): deflake sync serialization concurrency test #7

Merged
fabi merged 1 commits from fix/deflake-sync-serialization-test into main 2026-06-16 13:38:16 +00:00

View File

@@ -583,10 +583,18 @@ async fn sync_chapters_serializes_concurrent_calls_for_same_manga(pool: PgPool)
.fetch_all(&pool)
.await
.unwrap();
assert_eq!(
alive,
vec!["A".to_string(), "B".to_string(), "C".to_string()],
"all chapters survive concurrent syncs that both contain them"
// The per-manga advisory lock serializes the two calls, but it cannot
// dictate WHICH commits last (spawn order is not guaranteed — under load
// it inverts), so two correct last-writer-wins outcomes are possible:
// - Y (list [A,B,C]) commits last → nothing dropped → [A,B,C].
// - X (list [A,B]) commits last → it soft-drops C, a key it never saw
// and which the next full sync re-adds → [A,B].
// The lock's job is to prevent a TORN result (a lost B, a half-applied
// drop), not to fix an order it cannot. Accept either serialization;
// anything else means the lock failed to serialize.
assert!(
alive == ["A", "B", "C"] || alive == ["A", "B"],
"concurrent syncs must leave a valid serialization, got {alive:?}"
);
}