Backend:
- Migration 0004_bookmarks_unique.sql adds a partial unique index on
(user_id, manga_id) WHERE chapter_id IS NULL. The 0001 UNIQUE
constraint over (user_id, manga_id, chapter_id) doesn't block dupes
when chapter_id is NULL under Postgres's default NULLS DISTINCT, so a
user could otherwise bookmark the same manga twice at the manga
level. Chapter-level dupes are still caught by the 0001 constraint.
- repo::bookmark with create / list_for_user / find_owner / delete.
create catches the 23505 unique violation and surfaces it as
AppError::Conflict so handlers return a clean 409.
- POST /api/v1/bookmarks { manga_id, chapter_id?, page? } — CurrentUser
required. Pre-validates the manga exists (404 if not) and, when
chapter_id is supplied, that the chapter belongs to that manga (also
404), so FK violations can't bubble up as 500s.
- DELETE /api/v1/bookmarks/{id} — owner-only. 404 if unknown, 403 if it
exists for another user, 204 on success. Idempotent: deleting an
already-deleted bookmark is 404, not 500.
- GET /api/v1/me/bookmarks — paged envelope, sorted by created_at DESC,
scoped to the current user so the URL itself can't be used to peek at
someone else's bookmarks.
Integration coverage in tests/api_bookmarks.rs (9 cases): create+list
returns only own; duplicate manga-level bookmark → 409; unknown manga
→ 404; unauthenticated POST → 401; user A cannot delete user B's
bookmark (403); unknown delete → 404; double-delete → 404, not 500;
/me/bookmarks requires auth; paged envelope shape on empty list.
Frontend:
- lib/api/bookmarks.ts with createBookmark / deleteBookmark /
listMyBookmarks. listMyBookmarksOrEmpty wraps the 401 case so pages
can render anonymously without try/catch boilerplate.
- /manga/[id] overview: pre-loads the user's bookmark list in its load
function and renders either:
- "★ Bookmarked" / "☆ Bookmark" toggle with aria-pressed when authed;
click POSTs or DELETEs and mutates a local working copy of the
bookmark list (optimistic UI without re-fetching);
- or a "Sign in to bookmark" link for anonymous users.
- /bookmarks page lists the current user's bookmarks (chapter-level
bookmarks link into the reader, manga-level back to the overview).
Anonymous users see a sign-in prompt instead of a 401 page.
E2E in e2e/bookmarks.spec.ts (3 cases): authed toggle round-trip
(bookmark, see in /bookmarks list, unbookmark); anonymous user gets the
sign-in CTA on the overview; anonymous /bookmarks shows the sign-in
prompt. Existing reader.spec.ts updated for the new
bookmark-signin/toggle test IDs.
Lockstep version bump to 0.7.0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
161 lines
5.3 KiB
TypeScript
161 lines
5.3 KiB
TypeScript
import { test, expect, type Page } from '@playwright/test';
|
|
|
|
const mangaId = '11111111-1111-1111-1111-111111111111';
|
|
const mangaFixture = {
|
|
id: mangaId,
|
|
title: 'Berserk',
|
|
author: 'Kentaro Miura',
|
|
description: 'A dark fantasy.',
|
|
cover_image_path: 'mangas/11111111-1111-1111-1111-111111111111/cover.png',
|
|
created_at: '2026-01-01T00:00:00Z',
|
|
updated_at: '2026-01-01T00:00:00Z'
|
|
};
|
|
const chaptersFixture = [
|
|
{
|
|
id: 'c1',
|
|
manga_id: mangaId,
|
|
number: 1,
|
|
title: 'The Brand',
|
|
page_count: 3,
|
|
created_at: '2026-01-01T00:00:00Z'
|
|
}
|
|
];
|
|
const pagesFixture = [
|
|
{
|
|
id: 'p1',
|
|
chapter_id: 'c1',
|
|
page_number: 1,
|
|
storage_key: 'mangas/m1/chapters/c1/pages/0001.png',
|
|
content_type: 'image/png'
|
|
},
|
|
{
|
|
id: 'p2',
|
|
chapter_id: 'c1',
|
|
page_number: 2,
|
|
storage_key: 'mangas/m1/chapters/c1/pages/0002.png',
|
|
content_type: 'image/png'
|
|
},
|
|
{
|
|
id: 'p3',
|
|
chapter_id: 'c1',
|
|
page_number: 3,
|
|
storage_key: 'mangas/m1/chapters/c1/pages/0003.png',
|
|
content_type: 'image/png'
|
|
}
|
|
];
|
|
|
|
async function mockReaderApis(page: Page) {
|
|
await page.route('**/api/v1/auth/me', (route) =>
|
|
route.fulfill({
|
|
status: 401,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({ error: { code: 'unauthenticated', message: 'unauthenticated' } })
|
|
})
|
|
);
|
|
await page.route('**/api/v1/me/bookmarks*', (route) =>
|
|
route.fulfill({
|
|
status: 401,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({ error: { code: 'unauthenticated', message: 'unauthenticated' } })
|
|
})
|
|
);
|
|
await page.route(`**/api/v1/mangas/${mangaId}`, (route) =>
|
|
route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify(mangaFixture)
|
|
})
|
|
);
|
|
await page.route(`**/api/v1/mangas/${mangaId}/chapters?*`, (route) =>
|
|
route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({
|
|
items: chaptersFixture,
|
|
page: { limit: 50, offset: 0, total: null }
|
|
})
|
|
})
|
|
);
|
|
await page.route(`**/api/v1/mangas/${mangaId}/chapters`, (route) =>
|
|
route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({
|
|
items: chaptersFixture,
|
|
page: { limit: 50, offset: 0, total: null }
|
|
})
|
|
})
|
|
);
|
|
await page.route(`**/api/v1/mangas/${mangaId}/chapters/1`, (route) =>
|
|
route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify(chaptersFixture[0])
|
|
})
|
|
);
|
|
await page.route(`**/api/v1/mangas/${mangaId}/chapters/1/pages`, (route) =>
|
|
route.fulfill({
|
|
status: 200,
|
|
contentType: 'application/json',
|
|
body: JSON.stringify({ pages: pagesFixture })
|
|
})
|
|
);
|
|
// Stub image bytes so the <img> doesn't 404 (1x1 transparent PNG).
|
|
const png = Buffer.from(
|
|
'89504e470d0a1a0a0000000d49484452000000010000000108060000001f15c4890000000d49444154789c63000100000005000158a3b62a0000000049454e44ae426082',
|
|
'hex'
|
|
);
|
|
await page.route('**/api/v1/files/**', (route) =>
|
|
route.fulfill({ status: 200, contentType: 'image/png', body: png })
|
|
);
|
|
}
|
|
|
|
test('manga overview shows title, cover, and a chapter list', async ({ page }) => {
|
|
await mockReaderApis(page);
|
|
await page.goto(`/manga/${mangaId}`);
|
|
|
|
await expect(page.getByTestId('manga-title')).toHaveText('Berserk');
|
|
await expect(page.getByTestId('manga-author')).toContainText('Kentaro Miura');
|
|
await expect(page.getByTestId('manga-cover')).toBeVisible();
|
|
await expect(page.getByTestId('chapter-list')).toContainText('Chapter 1');
|
|
await expect(page.getByTestId('bookmark-signin')).toBeVisible();
|
|
});
|
|
|
|
test('reader paginates with arrow keys and j/k, and preloads the next page', async ({ page }) => {
|
|
await mockReaderApis(page);
|
|
await page.goto(`/manga/${mangaId}/chapter/1`);
|
|
|
|
// Page 1 shown, preload for page 2 in the DOM.
|
|
await expect(page.getByTestId('page-indicator')).toHaveText('Page 1 / 3');
|
|
await expect(page.getByTestId('reader-page')).toHaveAttribute(
|
|
'src',
|
|
/0001\.png$/
|
|
);
|
|
await expect(page.getByTestId('reader-preload')).toHaveAttribute(
|
|
'src',
|
|
/0002\.png$/
|
|
);
|
|
|
|
// ArrowRight → page 2.
|
|
await page.keyboard.press('ArrowRight');
|
|
await expect(page.getByTestId('page-indicator')).toHaveText('Page 2 / 3');
|
|
await expect(page.getByTestId('reader-page')).toHaveAttribute(
|
|
'src',
|
|
/0002\.png$/
|
|
);
|
|
|
|
// j → page 3 (last).
|
|
await page.keyboard.press('j');
|
|
await expect(page.getByTestId('page-indicator')).toHaveText('Page 3 / 3');
|
|
await expect(page.getByTestId('reader-next')).toBeDisabled();
|
|
|
|
// k → page 2.
|
|
await page.keyboard.press('k');
|
|
await expect(page.getByTestId('page-indicator')).toHaveText('Page 2 / 3');
|
|
|
|
// ArrowLeft → page 1.
|
|
await page.keyboard.press('ArrowLeft');
|
|
await expect(page.getByTestId('page-indicator')).toHaveText('Page 1 / 3');
|
|
await expect(page.getByTestId('reader-prev')).toBeDisabled();
|
|
});
|