Surfaced + fixed during the F3 attestation:
- executor-core/sdk/queue.rs: drop redundant .map(|()| ()) call sites;
enqueue_blocking discards QueueMessageId via .map(|_id| ()) (intentional)
- executor-core/sdk/retry.rs: hoist use std::collections::hash_map::DefaultHasher
+ use std::hash::Hasher to the top of the file (clippy::items_after_statements);
replace `as i64` casts with i64::try_from + clear comment about jitter
bound (clippy::cast_possible_wrap)
- executor-core/sdk/invoke.rs: move _LIMITS_IS_COPY const before #[cfg(test)]
mod tests (clippy::items_after_test_module)
- manager-core/dispatcher.rs: dispatch_one_queue gains #[allow(too_many_lines)]
(it's the queue tick's whole logic — split makes it less readable than
the lint); .map(...).unwrap_or(default) → .map_or(default, ...)
- picloud/lib.rs: Limits { trigger_depth_max, ..Limits::default() } via
struct-update instead of let-mut-assign (clippy::field_reassign_with_default)
- tests: r#"..."# → r"..." where there are no `"` inside (clippy::needless_raw_string_hashes);
combine InvokeTarget::Name | InvokeTarget::Path arms with identical bodies
in sdk_invoke.rs (clippy::match_same_arms)
cargo fmt --all -- --check 2>&1 | tail -3: no output (exit 0)
cargo clippy --workspace --all-targets --all-features -- -D warnings:
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.41s
Workspace lib smoke: 432 passing (306 manager-core + 74 executor-core + 34 shared + 18 orchestrator-core).
DB-gated E2E (against docker compose postgres on localhost:15432):
queue_e2e: 4 ok / invoke_e2e: 4 ok / retry_e2e: 3 ok / migration_queue_messages: 4 ok / schema_snapshot: 1 ok
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
172 lines
5.8 KiB
Rust
172 lines
5.8 KiB
Rust
//! `retry::*` SDK bridge integration tests — runs real Rhai scripts
|
|
//! that build a Policy, wrap a closure, and verify the retry / on_codes
|
|
//! behavior end-to-end. Sleep delays are kept to 1ms so the suite runs
|
|
//! fast.
|
|
|
|
use std::collections::BTreeMap;
|
|
use std::sync::{Arc, Mutex};
|
|
|
|
use picloud_executor_core::{Engine, ExecRequest, InvocationType, Limits};
|
|
use picloud_shared::{
|
|
AppId, ExecutionId, NoopDeadLetterService, NoopDocsService, NoopEmailService, NoopEventEmitter,
|
|
NoopFilesService, NoopHttpService, NoopInvokeService, NoopKvService, NoopModuleSource,
|
|
NoopPubsubService, NoopQueueService, NoopSecretsService, NoopUsersService, RequestId, ScriptId,
|
|
ScriptSandbox, Services,
|
|
};
|
|
use serde_json::Value;
|
|
|
|
fn build_engine() -> Arc<Engine> {
|
|
let services = Services::new(
|
|
Arc::new(NoopKvService),
|
|
Arc::new(NoopDocsService),
|
|
Arc::new(NoopDeadLetterService),
|
|
Arc::new(NoopEventEmitter),
|
|
Arc::new(NoopModuleSource),
|
|
Arc::new(NoopHttpService),
|
|
Arc::new(NoopFilesService),
|
|
Arc::new(NoopPubsubService),
|
|
Arc::new(NoopSecretsService),
|
|
Arc::new(NoopEmailService),
|
|
Arc::new(NoopUsersService),
|
|
Arc::new(NoopQueueService),
|
|
Arc::new(NoopInvokeService),
|
|
);
|
|
Arc::new(Engine::new(Limits::default(), services))
|
|
}
|
|
|
|
fn baseline_request(app_id: AppId) -> ExecRequest {
|
|
let execution_id = ExecutionId::new();
|
|
ExecRequest {
|
|
execution_id,
|
|
request_id: RequestId::new(),
|
|
script_id: ScriptId::new(),
|
|
script_name: "retry-test".into(),
|
|
invocation_type: InvocationType::Http,
|
|
path: "/retry-test".into(),
|
|
headers: BTreeMap::new(),
|
|
body: Value::Null,
|
|
params: BTreeMap::new(),
|
|
query: BTreeMap::new(),
|
|
rest: String::new(),
|
|
sandbox_overrides: ScriptSandbox::default(),
|
|
app_id,
|
|
principal: None,
|
|
trigger_depth: 0,
|
|
root_execution_id: execution_id,
|
|
is_dead_letter_handler: false,
|
|
event: None,
|
|
}
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn retry_run_succeeds_first_try() {
|
|
let engine = build_engine();
|
|
let src = r"
|
|
let p = retry::policy(#{ max_attempts: 3, base_ms: 1 });
|
|
let v = retry::run(p, || 42);
|
|
#{ statusCode: 200, body: v }
|
|
"
|
|
.to_string();
|
|
let req = baseline_request(AppId::new());
|
|
let resp = tokio::task::spawn_blocking(move || engine.execute(&src, req))
|
|
.await
|
|
.unwrap()
|
|
.unwrap();
|
|
assert_eq!(resp.body, serde_json::json!(42));
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn retry_run_surfaces_after_max_attempts() {
|
|
let engine = build_engine();
|
|
let src = r#"
|
|
let p = retry::policy(#{ max_attempts: 3, base_ms: 1, jitter_pct: 0 });
|
|
retry::run(p, || { throw "boom" });
|
|
"#
|
|
.to_string();
|
|
let req = baseline_request(AppId::new());
|
|
let res = tokio::task::spawn_blocking(move || engine.execute(&src, req))
|
|
.await
|
|
.unwrap();
|
|
let err = res.unwrap_err().to_string();
|
|
assert!(err.contains("boom"), "expected 'boom' in error, got: {err}");
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn retry_on_codes_filters_unmatched_errors() {
|
|
let engine = build_engine();
|
|
// Throw a message NOT in the filter; retry::run must surface
|
|
// immediately (no retries).
|
|
let src = r#"
|
|
let p = retry::policy(#{ max_attempts: 5, base_ms: 1, jitter_pct: 0 });
|
|
let p2 = retry::on_codes(p, ["http: 503"]);
|
|
retry::run(p2, || { throw "other failure" });
|
|
"#
|
|
.to_string();
|
|
let req = baseline_request(AppId::new());
|
|
let res = tokio::task::spawn_blocking(move || engine.execute(&src, req))
|
|
.await
|
|
.unwrap();
|
|
let err = res.unwrap_err().to_string();
|
|
assert!(
|
|
err.contains("other failure"),
|
|
"expected immediate surface, got: {err}"
|
|
);
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn retry_policy_clamps_visible_at_script_layer() {
|
|
// jitter_pct = 999 should clamp to 100 silently; the policy is then
|
|
// usable.
|
|
let engine = build_engine();
|
|
let src = r#"
|
|
let p = retry::policy(#{
|
|
max_attempts: 30, base_ms: 100, jitter_pct: 999, backoff: "constant"
|
|
});
|
|
let v = retry::run(p, || 1);
|
|
#{ statusCode: 200, body: v }
|
|
"#
|
|
.to_string();
|
|
let req = baseline_request(AppId::new());
|
|
let resp = tokio::task::spawn_blocking(move || engine.execute(&src, req))
|
|
.await
|
|
.unwrap()
|
|
.unwrap();
|
|
assert_eq!(resp.body, serde_json::json!(1));
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn retry_policy_rejects_bogus_backoff() {
|
|
let engine = build_engine();
|
|
let src = r#"retry::policy(#{ backoff: "bogus" });"#.to_string();
|
|
let req = baseline_request(AppId::new());
|
|
let res = tokio::task::spawn_blocking(move || engine.execute(&src, req))
|
|
.await
|
|
.unwrap();
|
|
assert!(res.is_err());
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn retry_run_eventually_succeeds() {
|
|
// Use an in-engine counter to simulate "fails 2 times then succeeds".
|
|
let engine = build_engine();
|
|
let counter = Arc::new(Mutex::new(0_i64));
|
|
let _ = counter; // counter via Rhai-side `let` instead
|
|
|
|
let src = r#"
|
|
let attempts = 0;
|
|
let p = retry::policy(#{ max_attempts: 5, base_ms: 1, jitter_pct: 0 });
|
|
let v = retry::run(p, || {
|
|
attempts += 1;
|
|
if attempts < 3 { throw "transient" } else { attempts }
|
|
});
|
|
#{ statusCode: 200, body: v }
|
|
"#
|
|
.to_string();
|
|
let req = baseline_request(AppId::new());
|
|
let resp = tokio::task::spawn_blocking(move || engine.execute(&src, req))
|
|
.await
|
|
.unwrap()
|
|
.unwrap();
|
|
assert_eq!(resp.body, serde_json::json!(3));
|
|
}
|