Adds optional per-script overrides for the six Rhai sandbox knobs
(max_operations, max_string_size, max_array_size, max_map_size,
max_call_levels, max_expr_depth). The executor merges its defaults
with each script's overrides on every call; the manager validates
overrides against an admin-set ceiling at write time, so the
executor trusts whatever is stored.
Storage chose JSONB on the existing scripts table over six new
columns: lets future knobs land as code-only changes, keeps the
sparse common case (most scripts override nothing) cheap to store
and serialize, and matches how the manager + executor pass the
config across the wire.
* 0002_sandbox.sql — ALTER TABLE scripts ADD COLUMN sandbox
JSONB NOT NULL DEFAULT '{}'
* shared::ScriptSandbox — six Option<u64> fields with
deny_unknown_fields so typos surface as 422
* Script.sandbox + ExecRequest.sandbox_overrides — typed end
to end; cluster mode just serializes the same struct
* executor-core::Limits::with_overrides — field-by-field
replacement; tests cover the override actually tightening
the live engine
* manager-core::SandboxCeiling — built-in conservative
defaults (10M ops, 1 MiB strings, 100k array/map, 128
call/expr depth); env vars override per knob, invalid
values warn-and-skip rather than blocking boot
* manager-core admin API — POST/PUT accept `sandbox`; values
above the ceiling return 422 with the specific field +
requested + ceiling; absent or `{}` keeps platform defaults
* picloud all-in-one — wires SandboxCeiling::from_env() into
AdminState
* memory_limit_mb stays in the schema, marked v1.3+ advisory
(no enforcement until OS-level isolation lands with
cluster-mode executors)
Verified live through Caddy:
* /version reports schema 2, product 0.3.0
* Script with max_operations: 500 → 507 on a 10k-iteration loop
* Same script after PUT raising to 1M → succeeds, returns 10000
* POST with max_operations: 1_000_000_000 → 422 (exceeds ceiling)
Tests:
* 13 executor-core unit tests (added 2 for override semantics)
* 20 integration tests (added 6 for sandbox CRUD + ceiling +
unknown-field rejection + executor honoring overrides)
* default cargo test --workspace stays green (integration tests
remain #[ignore]'d until DATABASE_URL is set)
Bumps:
* schema 1 → 2
* product 0.2.0 → 0.3.0
* SDK unchanged (scripts see nothing new)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8.0 KiB
Versioning
PiCloud carries one product version for the build you install, and independent versions on the four contracts that actually break for users. The product version answers "which build do I have"; surface versions answer "which contracts does that build honor".
This split exists because crate-level SemVer between, say, picloud-shared and picloud-manager-core is fiction — they always ship together. The boundaries that matter are user-facing: scripts depending on the SDK, callers hitting the HTTP API, databases shared across deploys, and (later) executor nodes talking to a manager.
What gets a version
Lockstep — one number for the whole thing
All of these carry the same version and are bumped together:
- Every crate in the Cargo workspace (via
version.workspace = true) - The dashboard's
package.json - Docker image tags (
picloud:0.2.0) - Git tags (
v0.2.0)
Defined once in Cargo.toml under [workspace.package]. There is no scenario where one crate is at a different version than another in the same build.
Independent — versioned at each surface
| Surface | Where the version lives | Format | Bump rule |
|---|---|---|---|
| Rhai SDK | shared::version::SDK_VERSION, exposed to scripts as ctx.sdk_version |
"major.minor" string |
Minor: additions; Major: removals/renames/retyped |
| HTTP API | URL prefix /api/v{N}/...; shared::version::API_VERSION is the current major |
integer | New integer when request/response shape, status semantics, or auth model changes |
| Database schema | Largest applied migration ID (manager-core::migrations::latest_version()) |
integer, monotonic | One per forward migration; never edit a committed file |
| Inter-service wire (cluster mode, v1.3+) | X-PiCloud-Wire request header; shared::version::WIRE_VERSION |
integer | New integer when RPC shape changes |
All five live in one place so /version can return them honestly.
Per-surface compatibility rules
Rhai SDK (strictest)
Scripts run in production with no recompile. A wrong SDK bump silently breaks user code.
- Patch (
1.2.0 → 1.2.1) — doc fixes, internal optimizations. No script-observable change. - Minor (
1.2 → 1.3) — added functions; added optionalctx.*fields; relaxed limits; new variants accepted alongside old ones. Every script written for 1.2 must still run unchanged on 1.3. - Major (
1 → 2) — anything removed, renamed, retyped, restricted, or made required.
Scripts can detect available features at runtime:
if ctx.sdk_version >= "1.2" {
// call kv.* (added in 1.2)
}
The contract test in crates/executor-core/tests/sdk_contract/ (coming alongside the first SDK additions) holds golden scripts that exercise every documented SDK surface. They must pass on every commit. A minor bump that breaks any of them is a build failure.
HTTP API
Path prefix is the version. Within a major, the following are non-breaking and welcome:
- New endpoints
- New optional request fields
- New response fields (clients must ignore unknown fields)
- New
Deprecation:headers warning of upcoming removals
The following require a new major (/api/v2/...):
- Removed endpoints, removed response fields, renamed fields
- Changed request-field types or required-field additions
- Changed status-code semantics for the same outcome
- Auth model changes
When vN+1 ships, vN stays live for at least one product minor (so users have a release cycle to migrate). Deprecation is announced via the Deprecation: true and Sunset: <date> response headers on the old prefix before removal.
Database schema
- Forward-only. Never edit a migration that has shipped. If a migration was wrong, write a new one that fixes it.
- Migrations are numbered sequentially (
0001_init.sql,0002_*.sql, ...). The number is the schema version. - A given binary applies migrations strictly greater than the last-applied ID, then refuses to start if its embedded migrations are older than what's in the DB — that would imply a downgrade, which is never automatic.
- This makes rolling deploys safe: the schema is always "ahead of or equal to" any running binary in the cluster.
Wire protocol (cluster mode, v1.3+)
- Inter-service RPCs include
X-PiCloud-Wire: N. - A peer that doesn't recognize
Nrefuses the call and returns426 Upgrade Requiredwith the version it speaks. - Both versions must be live in the cluster during rolling upgrades — current and current-minus-one — until all nodes agree on the new one.
How we check and enforce
A versioning scheme without enforcement decays in months. Five cheap mechanical checks:
- Compile-time uniformity. All workspace crates inherit
version.workspace = true. Drift is impossible to introduce. - Runtime self-report.
GET /versionreturns every surface version. Dashboards, monitoring, inter-service handshakes, and humans all read from one source./healthzstays a plain"ok"string for k8s probes — version negotiation is a separate concern. - Golden SDK contract tests.
tests/sdk_contract/Rhai scripts exercise every SDK surface and must pass on every commit. The contract is the test. - Migration replay test. An integration test that boots a fresh Postgres, applies every migration in order, and asserts the resulting schema. Catches the most common mistake (edited-not-added migration).
- CI guardrail script. A small diff-aware check that:
- Fails if
SDK_VERSION's major changed without aCHANGELOG.mdbreaking-change entry - Fails if a new file appeared in
migrations/that isn't the next sequential number - Fails if a route handler removed or retyped a public field without a
BREAKING:line in the commit message
- Fails if
(3) through (5) are wired in over the next few PRs; (1) and (2) land in the same commit as this document.
When to bump what
The product version follows SemVer applied pragmatically — we're pre-1.0, so the rules are looser:
- Patch (
0.2.0 → 0.2.1) — bug fixes, no surface change - Minor (
0.2 → 0.3) — any surface bump, new features, or breaking changes (pre-1.0 license) - Major (
0 → 1) — first stable release; SDK and API both committed to long-term compatibility
After 1.0, the product version follows strict SemVer based on the worst surface change:
- Any surface major bump → product major bump
- Any surface minor bump → product minor bump (at minimum)
- No surface changes → product patch
A surface can hit its own 1.0 independently of the product. The SDK in particular is likely to stabilize before the platform does, since scripts in production demand it.
Current versions
| Version | |
|---|---|
| Product | 0.3.0 |
| SDK | 1.0 |
| API | 1 |
| Schema | 2 (matches migrations/0002_sandbox.sql) |
| Wire | 1 (reserved; cluster mode not implemented) |
Read live from GET /version on any running instance.
Examples
Adding a kv.* SDK in v1.1+:
- Workspace bump:
0.2.0 → 0.3.0(pre-1.0 minor) - SDK bump:
"1.0" → "1.1"(added functions only) - API bump: none (no new endpoints affect existing API contract)
- Schema bump:
1 → 2(0002_kv_store.sqladds thekv_storetable)
Renaming ctx.execution_id to ctx.exec_id:
- SDK bump:
"1.x" → "2.0"(breaking) - Product: minor bump pre-1.0, major bump post-1.0
- Migration path: keep
ctx.execution_idavailable in 1.x for a deprecation window, addctx.exec_idalongside; flip to 2.0 only when both fields have shipped together for a release.
Adding pagination to GET /api/v1/admin/scripts:
- New optional
?limit=&offset=query params with sensible defaults → no API bump - Response keeps the same shape; clients that don't pass
limitsee the old behavior → no API bump
Changing the response shape of GET /api/v1/admin/scripts/{id} to wrap in { script: {...} }:
- Breaking. Ship as
/api/v2/admin/scripts/{id}. Keep/api/v1live until at least one product minor passes.