fabi/Sylpheed
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Re-propose the OPTIONS menu work as a reviewable pull request #6

New Issue
Open
opened 2026-09-04 15:48:07 +00:00 by fabi · 1 comment
fabi commented 2026-09-04 15:48:07 +00:00
Owner
Copy Link

The code exists and is probably fine. What it never had was a review.

This is not a rewrite. Bring the OPTIONS menu work onto main as one reviewable PR with Closes #N, sized so a person can read the diff in one sitting — if it is too big to review in one sitting it was too big to be one item, and it should be split here rather than argued about later.

Pass: a diff a human reads and approves; no long-lived branch left carrying it.

The code exists and is probably fine. **What it never had was a review.** This is not a rewrite. Bring the OPTIONS menu work onto `main` as one reviewable PR with `Closes #N`, sized so a person can read the diff in one sitting — if it is too big to review in one sitting it was too big to be one item, and it should be split here rather than argued about later. **Pass:** a diff a human reads and approves; no long-lived branch left carrying it.
fabi added this to the Menus milestone 2026-09-04 15:48:07 +00:00
fabi added the agent/portstate/proposedkind/item labels 2026-09-04 15:48:07 +00:00
fabi added state/approved and removed state/proposed labels 2026-09-04 15:59:17 +00:00
fabi commented 2026-09-17 19:02:14 +00:00
Author
Owner
Copy Link

Recovered. The code this asks for lived only on auto/port-p6-audio, which was deleted from the server during the 2026-09-17 cleanup. It is now branch recover/options-menu (35cb28e): the nine files the OPTIONS commits of 2026-09-03 touched — 3efe1cc (export GP_OPTIONS), 4c24e06 (name the 14 screens), a921c1e (OPTIONS reachable from the main menu), 41f1331 (0x3003 is a button too), 6b4b1df, 77f1d18, fda417a, 80042cb, edf8979 — taken at the state of the branch tip 0148cb8.

Read it as a review slice, not a buildable tree: the OPTIONS work and the F5/F6 work interleaved commit by commit (docs/port/DECISIONS.md alone was touched 257 times), so these files also carry whatever else had changed in them by 2026-09-04, and some of what they depend on is not here. The complete state is recover/port-f5-f6 (#7).

Both branches are snapshots parented on e53d687, the fork point, so the diff against that parent is exactly what the deleted branch did, and the 854 exported game assets it also carried are left out.

What this item still asks for is unchanged — a PR a human can read in one sitting — now with a rebase over the 613 commits main has gained since the fork point.

**Recovered.** The code this asks for lived only on `auto/port-p6-audio`, which was deleted from the server during the 2026-09-17 cleanup. It is now branch **`recover/options-menu`** (`35cb28e`): the nine files the OPTIONS commits of 2026-09-03 touched — `3efe1cc` (export `GP_OPTIONS`), `4c24e06` (name the 14 screens), `a921c1e` (OPTIONS reachable from the main menu), `41f1331` (`0x3003` is a button too), `6b4b1df`, `77f1d18`, `fda417a`, `80042cb`, `edf8979` — taken at the state of the branch tip `0148cb8`. Read it as a **review slice, not a buildable tree**: the OPTIONS work and the F5/F6 work interleaved commit by commit (`docs/port/DECISIONS.md` alone was touched 257 times), so these files also carry whatever else had changed in them by 2026-09-04, and some of what they depend on is not here. The complete state is `recover/port-f5-f6` (#7). Both branches are snapshots parented on `e53d687`, the fork point, so the diff against that parent is exactly what the deleted branch did, and the 854 exported game assets it also carried are left out. What this item still asks for is unchanged — a PR a human can read in one sitting — now with a rebase over the 613 commits `main` has gained since the fork point.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
agent/decoder
Owned by the Decoder (disc to meaning; runs the emulator)
 agent/port
Owned by the Port (disc to playable; no RE)
 kind/ask
One agent asking the other for something it cannot answer in role
 kind/bundle
A bundle the human defined; agents decompose it into items
 kind/defect
Found by a play-test or a check
 kind/item
One unit of work, small enough to finish in a single session
 state/approved
Human approved the shape; an agent may start
 state/blocked
Waiting on another item; use the Depends-On field, not prose
 state/in-progress
An agent is working it now
 state/needs-human
Done as far as an agent can tell -- a person must look. The body says what to look at
 state/proposed
Agent proposed this item; awaiting the human's approval to start
No Label agent/port kind/item state/approved
Milestone
No items
No Milestone Menus
Projects
Clear projects
No project
Assignees
Clear assignees
sylph-decoder sylph-pi sylph-port fabi
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fabi/Sylpheed#6
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?