fabi/Sylpheed
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

docs(agents): a red PR is the next unit of work, and check the workspace #24

Merged
fabi merged 1 commits from fix/loop-verify-own-pr into main 2026-09-12 14:27:09 +00:00
Conversation 1 Commits 1 Files Changed 2 +35
fabi commented 2026-09-11 20:05:16 +00:00
Owner
Copy Link

Two gaps the first post-migration decoder iteration exposed. Both are the same shape: the loop ends before it can observe its own result.

1 · Nothing brings an agent back to its own red PR. Step 1 read notifications; it never looked at the agent's open PRs. The decoder opened #23, labelled #8 state/needs-human, and stopped — correctly, per the brief. #23 is red, and the agent's stated plan for its next firing was to start a new question on top of it.

2 · cargo build -p sylpheed-cli was accepted as "the merge is resolved". The conflict was in sylpheed-cli. The breakage is in sylpheed-viewer, which neither side of the merge edited: this branch added a ComposeOptions field, main had a literal construction of it. Nothing in the conflict pointed at the file that broke.

The crate you just fixed is the one place the break cannot be, because you just looked at it.

Both briefs get both changes — the Port merges origin/main on the same step and has the same exposure.

Two gaps the **first post-migration decoder iteration** exposed. Both are the same shape: the loop ends before it can observe its own result. **1 · Nothing brings an agent back to its own red PR.** Step 1 read notifications; it never looked at the agent's open PRs. The decoder opened #23, labelled #8 `state/needs-human`, and stopped — correctly, per the brief. #23 is red, and the agent's stated plan for its next firing was to start a *new* question on top of it. **2 · `cargo build -p sylpheed-cli` was accepted as "the merge is resolved".** The conflict was in `sylpheed-cli`. The breakage is in `sylpheed-viewer`, which **neither side of the merge edited**: this branch added a `ComposeOptions` field, `main` had a literal construction of it. Nothing in the conflict pointed at the file that broke. > The crate you just fixed is the one place the break cannot be, because you just looked at it. Both briefs get both changes — the Port merges `origin/main` on the same step and has the same exposure.
fabi added 1 commit 2026-09-11 20:05:16 +00:00
docs(agents): a red PR is the next unit of work, and check the workspace
All checks were successful
CI / Native — linux (pull_request) Successful in 36m19s
Details
CI / WASM — Web (pull_request) Successful in 30m41s
Details
CI / Formatting (pull_request) Successful in 54s
Details
cddf2af3b4 
Two gaps the first post-migration decoder iteration exposed, both in the same
place — the loop ends before it can observe its own result.

1. Step 1 read notifications but never looked at the agent's own open PRs. It
   opened #23, labelled the issue `state/needs-human`, and stopped; nothing in
   the brief would ever bring it back to a red check. Next iteration it planned
   to start a new question on top.

2. It called the merge resolved on `cargo build -p sylpheed-cli` — the crate the
   conflict was in. The break was in `sylpheed-viewer`, which neither side of
   the merge edited: one branch added a `ComposeOptions` field, the other had a
   literal construction of it. The crate you just fixed is the one place the
   breakage cannot be.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sylph-decoder commented 2026-09-11 20:26:56 +00:00
Collaborator
Copy Link

Confirmed against the real case: cargo check --workspace --all-targets on
auto/frame-blend-draw-path after the main merge found exactly the
sylpheed-viewer/ComposeOptions::at break this PR describes, invisible to
cargo build -p sylpheed-cli. Fixed in #23 (7c5a4a6) by matching the field's
documented default (at: None) rather than touching Explorer behavior.
One data point in favor of landing this guidance as written.

Confirmed against the real case: `cargo check --workspace --all-targets` on `auto/frame-blend-draw-path` after the `main` merge found exactly the `sylpheed-viewer`/`ComposeOptions::at` break this PR describes, invisible to `cargo build -p sylpheed-cli`. Fixed in #23 (7c5a4a6) by matching the field's documented default (`at: None`) rather than touching Explorer behavior. One data point in favor of landing this guidance as written.
fabi merged commit 90a0a5b862 into main 2026-09-12 14:27:09 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
agent/decoder
Owned by the Decoder (disc to meaning; runs the emulator)
 agent/port
Owned by the Port (disc to playable; no RE)
 kind/ask
One agent asking the other for something it cannot answer in role
 kind/bundle
A bundle the human defined; agents decompose it into items
 kind/defect
Found by a play-test or a check
 kind/item
One unit of work, small enough to finish in a single session
 state/approved
Human approved the shape; an agent may start
 state/blocked
Waiting on another item; use the Depends-On field, not prose
 state/in-progress
An agent is working it now
 state/needs-human
Done as far as an agent can tell -- a person must look. The body says what to look at
 state/proposed
Agent proposed this item; awaiting the human's approval to start
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
sylph-decoder sylph-pi sylph-port fabi
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fabi/Sylpheed#24
Delete Branch "fix/loop-verify-own-pr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?