Fabian Hamm
ed54f95d54
`cargo fmt --all -- --check` has failed on every run in this repository's history, identically on `main` and on every branch. This is #12. Mechanical: `cargo fmt --all`, nothing else. 154 files, all `.rs`, no other extension touched. `cargo check --workspace` exits 0 afterwards, so nothing changed semantically. ON THE ORDERING, WHICH WAS THE REAL QUESTION. HANDOFF-2026-09-06 section 7 warns this is the expensive fix: a whole-tree reformat before #7 and #8 return "would put a conflict in every file of 861 commits and make the reviews those items exist to enable unreadable". That is measurably too pessimistic, and it had been reasoned rather than tested. Measured here by three-way merging a rustfmt'd `main` against both unmerged branches, file by file: file/branch pairs tested 32 merges CLEAN 28 merges CONFLICTING 4 (8 conflict hunks total) sylpheed-cli/src/main.rs 1 hunk sylpheed-export/src/check.rs 1 sylpheed-export/src/screen.rs 4 sylpheed-export/src/video.rs 2 All four are against `auto/frame-blend-draw-path` only; `auto/port-p6-audio` does not conflict anywhere. The earlier framing -- 154 dirty files, 133 that cannot collide, 21 that can, the collision set carrying 147 of 774 hunks (19%) -- reproduces exactly. What it did not say is that most of the 21 still merge cleanly, because rustfmt's edits and the branches' edits rarely land on the same lines. So the cost of sweeping now is 4 files and 8 hunks for one branch, against a check that is otherwise red forever. Deliberately NOT folded into the WASM PR: 154 reformatted files would make that one unreviewable. Closes #12
58 lines
2.2 KiB
Rust
58 lines
2.2 KiB
Rust
//! Do real index buffers address their whole vertex pool?
|
||
//!
|
||
//! `validate_block` rejects a block whose indices reach fewer than `vtx_count−4`
|
||
//! vertices ("buffer not covered"). That gate is the furthest-reached rejection
|
||
//! for a handful of resources that never decode — so the question is whether it
|
||
//! is well founded. This measures the slack on every block that DOES decode: if
|
||
//! real geometry always covers its pool, under-coverage is good evidence of a
|
||
//! wrong candidate and the gate stands.
|
||
use std::collections::BTreeMap;
|
||
use sylpheed_formats::mesh::Xbg7Model;
|
||
|
||
fn main() {
|
||
let dir = std::env::args().nth(1).expect("resource3d dir");
|
||
let mut files: Vec<_> = std::fs::read_dir(&dir)
|
||
.unwrap()
|
||
.flatten()
|
||
.map(|e| e.path())
|
||
.filter(|p| p.extension().and_then(|s| s.to_str()) == Some("xpr"))
|
||
.collect();
|
||
files.sort();
|
||
|
||
let mut hist: BTreeMap<i64, usize> = BTreeMap::new();
|
||
let mut worst: Vec<(i64, String)> = Vec::new();
|
||
for f in &files {
|
||
let Ok(bytes) = std::fs::read(f) else {
|
||
continue;
|
||
};
|
||
for m in Xbg7Model::anchor_models_cancellable(&bytes, 0.0, &|| false) {
|
||
for sub in &m.meshes {
|
||
if sub.positions.is_empty() || sub.indices.is_empty() {
|
||
continue;
|
||
}
|
||
let max_idx = *sub.indices.iter().max().unwrap() as i64;
|
||
let slack = sub.positions.len() as i64 - 1 - max_idx;
|
||
*hist.entry(slack.min(20)).or_default() += 1;
|
||
if slack > 4 {
|
||
worst.push((
|
||
slack,
|
||
format!("{} in {}", m.name, f.file_name().unwrap().to_string_lossy()),
|
||
));
|
||
}
|
||
}
|
||
}
|
||
}
|
||
println!("unreferenced tail vertices (vtx_count − 1 − max index), over decoded sub-meshes:");
|
||
for (slack, n) in &hist {
|
||
println!(
|
||
" {:>3}{} : {n}",
|
||
slack,
|
||
if *slack == 20 { "+" } else { " " }
|
||
);
|
||
}
|
||
worst.sort_by_key(|(s, _)| std::cmp::Reverse(*s));
|
||
for (s, w) in worst.iter().take(5) {
|
||
println!(" largest slack {s}: {w}");
|
||
}
|
||
}
|