Fabian Hamm
ed54f95d54
`cargo fmt --all -- --check` has failed on every run in this repository's history, identically on `main` and on every branch. This is #12. Mechanical: `cargo fmt --all`, nothing else. 154 files, all `.rs`, no other extension touched. `cargo check --workspace` exits 0 afterwards, so nothing changed semantically. ON THE ORDERING, WHICH WAS THE REAL QUESTION. HANDOFF-2026-09-06 section 7 warns this is the expensive fix: a whole-tree reformat before #7 and #8 return "would put a conflict in every file of 861 commits and make the reviews those items exist to enable unreadable". That is measurably too pessimistic, and it had been reasoned rather than tested. Measured here by three-way merging a rustfmt'd `main` against both unmerged branches, file by file: file/branch pairs tested 32 merges CLEAN 28 merges CONFLICTING 4 (8 conflict hunks total) sylpheed-cli/src/main.rs 1 hunk sylpheed-export/src/check.rs 1 sylpheed-export/src/screen.rs 4 sylpheed-export/src/video.rs 2 All four are against `auto/frame-blend-draw-path` only; `auto/port-p6-audio` does not conflict anywhere. The earlier framing -- 154 dirty files, 133 that cannot collide, 21 that can, the collision set carrying 147 of 774 hunks (19%) -- reproduces exactly. What it did not say is that most of the 21 still merge cleanly, because rustfmt's edits and the branches' edits rarely land on the same lines. So the cost of sweeping now is 4 files and 8 hunks for one branch, against a check that is otherwise red forever. Deliberately NOT folded into the WASM PR: 154 reformatted files would make that one unreviewable. Closes #12
57 lines
2.4 KiB
Rust
57 lines
2.4 KiB
Rust
//! Is `BGM_103` the ONLY bank with those two wave sizes?
|
|
//!
|
|
//! `authored/audio.json` says *"Static code, disc census and runtime all agree"*
|
|
//! — three legs. Reading the sentence beneath it, legs two and three are **one**
|
|
//! comparison: the disc's declared wave sizes matched byte-for-byte against what
|
|
//! the XMA probe saw at the menu. That is a disc-to-runtime match, not two
|
|
//! independent confirmations.
|
|
//!
|
|
//! It is a third leg only if the census independently EXCLUDES alternatives — if
|
|
//! some other bank carried the same two sizes, the byte match would not
|
|
//! distinguish it. So the sizes are counted across every `BGM_*` bank on the
|
|
//! disc.
|
|
//!
|
|
//! Prompted by the Decoder's point that a decorative second support is worse
|
|
//! than none: **a conclusion with two supports reads as better evidenced than
|
|
//! one with a single support, so apparent redundancy is itself the
|
|
//! misinformation.**
|
|
use sylpheed_formats::media;
|
|
|
|
fn main() {
|
|
let root = std::env::var("SYLPHEED_DISC").unwrap_or_else(|_| "/disc".into());
|
|
let src = media::DirectorySource::new(&root);
|
|
const WANT: [usize; 2] = [3_876_864, 3_930_112];
|
|
let (mut found, mut matches) = (0usize, Vec::new());
|
|
for n in 0..=199u32 {
|
|
let name = format!("BGM_{n:03}.slb");
|
|
let Ok(riffs) = media::sound_bank_riffs(&src, &name) else {
|
|
continue;
|
|
};
|
|
if riffs.is_empty() {
|
|
continue;
|
|
}
|
|
found += 1;
|
|
let sizes: Vec<usize> = riffs.iter().map(|r| r.len()).collect();
|
|
// Compare on the DATA payload the port sums, not on the RIFF wrapper:
|
|
// a wrapper differs by header bytes and would hide a real collision.
|
|
let near = sizes
|
|
.iter()
|
|
.any(|s| WANT.iter().any(|w| s.abs_diff(*w) < 4096));
|
|
if near {
|
|
matches.push((name.clone(), sizes.clone()));
|
|
}
|
|
}
|
|
println!(" {found} BGM_* bank(s) readable on this disc");
|
|
for (n, s) in &matches {
|
|
println!(" {n:<14} wave sizes {s:?}");
|
|
}
|
|
println!(
|
|
"\n {} bank(s) carry a wave within 4 KiB of {WANT:?}",
|
|
matches.len()
|
|
);
|
|
println!(" Exactly 1 means the census EXCLUDES alternatives and is a real third");
|
|
println!(" leg. More than 1 means the byte match does not distinguish BGM_103,");
|
|
println!(" and \"three legs\" is two. Zero means this reader cannot see the");
|
|
println!(" incumbent and its answer means nothing.");
|
|
}
|