a23c321831
Takes the port branch up to77320d5e-- the state the human play-tested on 2026-09-02 -- for SOURCE paths only. Not a branch merge: `auto/port-p6-audio` is 366 commits and 938 files, and most of that must not land. WHAT COMES IN (76 files, all human-confirmed working): * the logo splash animation.08ed3dd1found it: `pose_at` ASSIGNED the settle instant instead of clamping to it, so the splash never animated at all -- and the same bug manufactured a passing harness result, because the harness photographed t past the settle. Confirmed by play-test: "cannot notice any obvious difference from the actual game." * gamepad input -- (A)/(B) bound additively (`ui_accept` ships with NO joypad binding), stick latched with hysteresis at the game's own 61% digitise threshold. This is what made (A), video-skip and Extras work at all. * menu navigation and flow, menu audio, the exporter, the authored declarations, and 23 verification tools under tools/port/. WHAT IS DELIBERATELY LEFT ON THE BRANCH: * everything afterc0ae460a-- the F5/F6 title-timing investigation, whose own tip commit calls itself a "hand-off for one-minute human checks". Unchecked by definition; it goes through the new review gate like anything else. * the OPTIONS menu work of 2026-09-03. Real, probably good, NOT play-tested. * the F1 repeat mechanism, which its own commit calls "deliberately inert". WHAT MUST NOT LAND, AND WHY THE .gitignore CHANGED: 545 MB of extracted game content was committed on that branch -- 850 sprite, audio and transcoded video files under `export-probe/` and `export-probe2/`, plus 246 MB of loose .wav and .tsv at the repo root. This repository's own rule, in this file, is "never game content". The rule was not missing. It was written, and it was tightened on that very branch, with a careful comment explaining why BOTH `export/` and `data/base/` had to be listed -- while the exporter was writing to a third name that nobody had thought to list. Enumerating names is the thing that failed. So the ignore rules now describe the SHAPE: any top-level `export*/`, game media by extension, and loose capture output at the root. Verified both ways -- it catches all four offenders and ignores nothing currently tracked. Verified: `cargo check --workspace` clean; all nine GDScript files parse in project context, with a positive control (an injected syntax error is detected, 3 lines) so the clean result means something. `tools/port/check-all` was NOT run -- it needs the container, the export tree and a display.
47 lines
2.6 KiB
Rust
47 lines
2.6 KiB
Rust
//! Do any screens THIS PORT SHIPS carry a record that declares a cycle while all
|
|
//! its poses sit at t = 0?
|
|
//!
|
|
//! The substantive finding from the denominator thread: 1 530 nested records
|
|
//! disc-wide are timed with every pose at t = 0 and still declare a nonzero
|
|
//! `+0x08`. A static record that declares a cycle length is a real thing, not a
|
|
//! counting artefact — so the question for the port is whether it holds one of
|
|
//! those still while the disc says it cycles.
|
|
//!
|
|
//! Scoped to `GP_TITLE`, because that is the archive the port exports.
|
|
use sylpheed_formats::{pak, ratc, ui_layout};
|
|
|
|
fn main() {
|
|
let root = std::env::var("SYLPHEED_DISC").unwrap_or_else(|_| "/disc".into());
|
|
let ar = pak::PakArchive::open(format!("{root}/dat/GP_TITLE.pak")).expect("GP_TITLE.pak");
|
|
let (mut total, mut hits, mut multipose) = (0usize, 0usize, 0usize);
|
|
for (i, e) in ar.entries().iter().enumerate() {
|
|
let Ok(by) = ar.read(e) else { continue };
|
|
if !ratc::is_ratc(&by) { continue }
|
|
let Some(b) = ui_layout::parse_build(&by) else { continue };
|
|
for (name, &(o, s)) in &b.records {
|
|
if o + 12 > by.len() || o + s > by.len() || &by[o..o + 4] != b"RATC" { continue }
|
|
let Some(lb) = ui_layout::parse_build(&by[o..o + s]) else { continue };
|
|
let maxt = lb.elements.iter()
|
|
.flat_map(|el| el.keyframes.iter().filter_map(|k| k.time)).max().unwrap_or(0);
|
|
let len = ui_layout::loop_length_units(&by[o..o + s]).unwrap_or(0);
|
|
total += 1;
|
|
if maxt == 0 && len > 0 {
|
|
hits += 1;
|
|
// A cycle can only produce motion if there is more than one pose
|
|
// to move between. All-at-t=0 with a single keyframe per element
|
|
// is visually inert however it is played.
|
|
let kf: usize = lb.elements.iter().map(|el| el.keyframes.len()).sum();
|
|
let multi = lb.elements.iter().filter(|el| el.keyframes.len() > 1).count();
|
|
if multi > 0 { multipose += 1 }
|
|
println!(" entry {i:>2} {name:<16} {len}-unit cycle, {kf} keyframe(s) \
|
|
across {} element(s), {multi} with >1 pose", lb.elements.len());
|
|
}
|
|
}
|
|
}
|
|
println!("\n {total} nested record(s) in GP_TITLE; {hits} declare a cycle while static.");
|
|
println!(" Of those, {multipose} have an element with MORE THAN ONE pose -- the only");
|
|
println!(" ones where looping could differ visibly from holding. A record whose");
|
|
println!(" elements each carry a single pose renders identically either way, so a");
|
|
println!(" declared cycle there is inert rather than a defect.");
|
|
}
|