fabi/Xenia-Canary
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing analysis regression: don't analyze on gets during analysis pass.

Browse Source
This commit is contained in:
Ben Vanik
2013-05-26 02:11:08 -07:00
parent f94256aaaf
commit 6b851da9d7
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/xenia/cpu/exec_module.cc
View File

@@ -153,7 +153,7 @@ int ExecModule::Init() {
}
FunctionSymbol* ExecModule::FindFunctionSymbol(uint32_t address) {
return sdb_->GetFunction(address);
return sdb_->GetFunction(address, true);
}
void ExecModule::Dump() {

6
src/xenia/cpu/sdb/symbol_database.cc
View File

@@ -147,7 +147,7 @@ VariableSymbol* SymbolDatabase::GetOrInsertVariable(uint32_t address) {
return var;
}
FunctionSymbol* SymbolDatabase::GetFunction(uint32_t address) {
FunctionSymbol* SymbolDatabase::GetFunction(uint32_t address, bool analyze) {
SymbolMap::iterator i = symbols_.find(address);
if (i != symbols_.end() && i->second->symbol_type == Symbol::Function) {
return static_cast<FunctionSymbol*>(i->second);
@@ -161,7 +161,9 @@ FunctionSymbol* SymbolDatabase::GetFunction(uint32_t address) {
symbols_.insert(SymbolMap::value_type(address, fn));
scan_queue_.push_back(fn);
FlushQueue();
if (analyze) {
FlushQueue();
}
return fn;
}

2
src/xenia/cpu/sdb/symbol_database.h
View File

@@ -39,7 +39,7 @@ public:
FunctionSymbol* GetOrInsertFunction(
uint32_t address, FunctionSymbol* opt_call_source = NULL);
VariableSymbol* GetOrInsertVariable(uint32_t address);
FunctionSymbol* GetFunction(uint32_t address);
FunctionSymbol* GetFunction(uint32_t address, bool analyze = false);
VariableSymbol* GetVariable(uint32_t address);
int GetAllVariables(std::vector<VariableSymbol*>& variables);