fabi/xenia-rs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(cpu): rename vmsum3fp_… to vmaddfp_lane_fma per reviewer nit

Browse Source 
P8 review feedback (non-blocking): the test fn name said vmsum3fp but
the encoding/body actually tests vmaddfp. Rename + clarify comment;
no behavior change.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
MechaCat02
2026-05-02 14:22:39 +02:00
parent 261480616c
commit 1f9696ad47
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
crates/xenia-cpu/src/interpreter.rs
View File

@@ -7354,11 +7354,10 @@ mod tests {
assert_eq!(r[15], 0xDD); assert_eq!(r[15], 0xDD);
} }
// PPCBUG-490 VMX multiply-sum. // PPCBUG-490 VMX multiply-add (vmaddfp; vmsum* covered indirectly by P5).
#[test] #[test]
fn vmsum3fp_horizontal_3lane_sum() { fn vmaddfp_lane_fma() {
// vmsum3fp128 (already tested in P5 indirectly); here test scalar vmsum4ubm. // Per-lane fused multiply-add: vD[i] = vA[i] * vC[i] + vB[i].
// Skip scalar VMX multiply-sum byte forms (large encoding); test vmaddfp.
let mut ctx = PpcContext::new(); let mut ctx = PpcContext::new();
let mut mem = TestMem::new(); let mut mem = TestMem::new();
ctx.vr[1] = xenia_types::Vec128::from_f32x4_array([2.0, 3.0, 4.0, 5.0]); ctx.vr[1] = xenia_types::Vec128::from_f32x4_array([2.0, 3.0, 4.0, 5.0]);