fabi/xenia-rs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(cpu): mcrfs uses fpscr::VX_ALL constant per reviewer nit

Browse Source 
P6 review nit: replace the inline `const VX_ALL_MASK` in the mcrfs arm
with the existing `fpscr::VX_ALL` constant (single source of truth).
Behaviorally identical.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
MechaCat02
2026-05-02 13:56:34 +02:00
parent 99e7814836
commit 5ece5e315f
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/xenia-cpu/src/interpreter.rs
View File

@@ -4736,11 +4736,7 @@ fn execute(ctx: &mut PpcContext, mem: &dyn MemoryAccess, instr: &DecodedInstr) -
// bit remains set, VX must remain set; if all are cleared, VX // bit remains set, VX must remain set; if all are cleared, VX
// must clear. (FEX recomputation omitted — xenia doesn't model // must clear. (FEX recomputation omitted — xenia doesn't model
// enabled-exception dispatch.) // enabled-exception dispatch.)
const VX_ALL_MASK: u32 = if ctx.fpscr & fpscr::VX_ALL != 0 {
fpscr::VXSNAN | fpscr::VXISI | fpscr::VXIDI |
fpscr::VXZDZ | fpscr::VXIMZ | fpscr::VXVC |
fpscr::VXSOFT | fpscr::VXSQRT | fpscr::VXCVI;
if ctx.fpscr & VX_ALL_MASK != 0 {
ctx.fpscr |= fpscr::VX; ctx.fpscr |= fpscr::VX;
} else { } else {
ctx.fpscr &= !fpscr::VX; ctx.fpscr &= !fpscr::VX;