fabi/Snappy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove MSan exemption for _bzhi_u32, since LLVM now handles it correctly.

Browse Source 
This cleans up a TODO from cl/225463783 and cl/225655713.

PiperOrigin-RevId: 241933185
This commit is contained in:
atdt
2019-04-04 08:17:45 -07:00
committed by Chris Mumford
parent d58cd618be
commit 02cf187555
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
snappy.cc
View File

@@ -718,9 +718,7 @@ static inline void Report(const char *algorithm, size_t compressed_size,
static inline uint32 ExtractLowBytes(uint32 v, int n) {
assert(n >= 0);
assert(n <= 4);
// TODO(b/121042345): Remove !defined(MEMORY_SANITIZER) once MSan
// handles _bzhi_u32() correctly.
#if SNAPPY_HAVE_BMI2 && !defined(MEMORY_SANITIZER)
#if SNAPPY_HAVE_BMI2
return _bzhi_u32(v, 8 * n);
#else
// This needs to be wider than uint32 otherwise `mask << 32` will be